js.c doesn't build under MOZ_SHARK

RESOLVED FIXED in mozilla1.9beta4

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: jorendorff, Assigned: jorendorff)

Tracking

Other Branch
mozilla1.9beta4
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Two trivial bugs: (1) in Makefile.ref, the "ifdef MOZ_SHARK" block comes a little too early, so the settings get clobbered; (2) in js.c, the js_ prefix is missing from some function names.

Patch in the morning (if nobody just checks in the quick, NPOTB fix in the meantime).
(Assignee)

Comment 1

10 years ago
Created attachment 303518 [details] [diff] [review]
v1
Assignee: general → jorendorff
Status: NEW → ASSIGNED
Attachment #303518 - Flags: review?(brendan)
Comment on attachment 303518 [details] [diff] [review]
v1

Thanks, sayrer can vouch for this too -- main thing is that it works!

/be
Attachment #303518 - Flags: review?(brendan)
Attachment #303518 - Flags: review+
Attachment #303518 - Flags: approval1.9+
Keywords: checkin-needed
Checking in js/src/Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.49; previous revision: 3.48
done
Checking in js/src/js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.197; previous revision: 3.196
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.