Closed Bug 417615 Opened 16 years ago Closed 16 years ago

js.c doesn't build under MOZ_SHARK

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta4

People

(Reporter: jorendorff, Assigned: jorendorff)

Details

Attachments

(1 file)

v1
2.64 KB, patch
brendan
: review+
brendan
: approval1.9+
Details | Diff | Splinter Review 
Two trivial bugs: (1) in Makefile.ref, the "ifdef MOZ_SHARK" block comes a little too early, so the settings get clobbered; (2) in js.c, the js_ prefix is missing from some function names.

Patch in the morning (if nobody just checks in the quick, NPOTB fix in the meantime).
Attached patch v1 — — Splinter Review 
Assignee: general → jorendorff
Status: NEW → ASSIGNED

        Attachment #303518 -
        Flags: review?(brendan)

    
    

    
  
Comment on attachment 303518 [details] [diff] [review]
v1

Thanks, sayrer can vouch for this too -- main thing is that it works!

/be

        Attachment #303518 -
        Flags: review?(brendan)

        Attachment #303518 -
        Flags: review+

        Attachment #303518 -
        Flags: approval1.9+

    
  
Keywords: checkin-needed

    
    

    
  
Checking in js/src/Makefile.ref;
/cvsroot/mozilla/js/src/Makefile.ref,v  <--  Makefile.ref
new revision: 3.49; previous revision: 3.48
done
Checking in js/src/js.c;
/cvsroot/mozilla/js/src/js.c,v  <--  js.c
new revision: 3.197; previous revision: 3.196
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9beta4
Flags: in-testsuite-
Flags: in-litmus-

          You need to log in
          before you can comment on or make changes to this bug.