417637 - tstclnt crashes if -p option is not specified

Status: RESOLVED FIXED

(NSS :: Tools, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1 (for trunk)

If tstclnt is invoked without the -p option, it is supposed to use port 443.
It does that, but then it crashes, because it tries to free a string that
wasn't malloc'ed.  
This patch fixes it.

Comment 1

[Julien Pierre]

Comment on attachment 303421 [details] [diff] [review]
patch v1 (for trunk)

This fixes the leak, but I think the following check is incorrect :

+    if (!host || portno == ((PRUint16)-1)) 
+    	Usage(progName);
 

That's because atoi will return 0 in failure cases, not -1. And we know port 0 is invalid for sure. So you you should check for 

(!host || !portno)

instead.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v2

Thanks, Julien.  I was thinking of the function strtol, which I typically use
instead of atoi and atol because it allows input to be hex or octal as well as 
decimal.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Checking in tstclnt.c; new revision: 1.49; previous revision: 1.48

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 303762 [details] [diff] [review]
patch v2

requesting second review for branch.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

tstclnt.c; new revision: 1.42.2.5; previous revision: 1.42.2.4