417645 - pkix_primhash_add should not throw error when caller attempt to add dup key/values pair.

Status: NEW

(NSS :: Libraries, enhancement, P2)

Description

[Alexei Volkov]

Running all.sh(strsclnt tests) on my machine produce leaks of object. Don't know why we do not see stress test failing on tinderboxes.

Stress client parametes: -q -p 10443 -d ../client -B -s -w nss -c 100 -C A -N -n TestUser goa1.red.iplanet.com

Some times need to run more than ones to reproduce the failure.

Leak report:
-139315536[8064580]: Class BigInt leaked 1 objects of size 8 bytes, total = 8 bytes
-139315536[8064580]: Class BuildResult leaked 1 objects of size 8 bytes, total = 8 bytes
-139315536[8064580]: Class Cert leaked 2 objects of size 136 bytes, total = 272 bytes
-139315536[8064580]: Class CertBasicConstraints leaked 1 objects of size 8 bytes, total = 8 bytes
-139315536[8064580]: Class CertStore leaked 1 objects of size 32 bytes, total = 32 bytes
-139315536[8064580]: Class Date leaked 3 objects of size 12 bytes, total = 36 bytes
-139315536[8064580]: Class List leaked 19 objects of size 20 bytes, total = 380 bytes
-139315536[8064580]: Class PublicKey leaked 2 objects of size 4 bytes, total = 8 bytes
-139315536[8064580]: Class TrustAnchor leaked 1 objects of size 16 bytes, total = 16 bytes
-139315536[8064580]: Class ValidateResult leaked 1 objects of size 12 bytes, total = 12 bytes
-139315536[8064580]: Class X500Name leaked 3 objects of size 24 bytes, total = 72 bytes
-139315536[8064580]: Assertion failure: secmod_PrivateModuleCount == 0, at pk11util.c:120
Assertion failure: secmod_PrivateModuleCount == 0, at pk11util.c:120
Aborted (core dumped)
Directory: /net/goa1.red.iplanet.com/export/SC/ws/nss-3.12-pkix-errors/mozilla/tests_results/security/goa1.5/client

Comment 1

[Alexei Volkov]

The reason of failure was change in pkix_pl_primhash.c: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/security/nss/lib/libpkix/pkix_pl_nss/system&command=DIFF_FRAMESET&file=pkix_pl_primhash.c&rev1=1.4&rev2=1.5&root=/cvsroot

Additional changes require to callers on the function to clean up objects if collision has occurred.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Previous change to not throw an error resulted in leaks, and so that change
was backed out, which fixed the leaks but reinstated the errors. 
The objective is to eliminate the errors and any new leaks.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Unsetting target milestone in unresolved bugs whose targets have passed.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, and this bug has priority 'P2'.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.