417679 - "get bounds of window 1" AppleScript fails with Camino 1.6b*

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, defect)

Description

[Lisa Thompson]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.13pre) Gecko/20080212 Camino/1.6b3pre (like Firefox/2.0.0.13pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en; rv:1.8.1.13pre) Gecko/20080212 Camino/1.6b3pre (like Firefox/2.0.0.13pre)

The Camino 1.6 Applescript dictionary omits "bounds" as a property of windows. For reference, "bounds" is usually included as a Standard Suite property of windows and inherited by application-specific window classes; that's how it is in Camino 1.5 as well as Safari 3.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Peter, I don't recall this being one of the planned deletions/modifications when we had to mess with the Standard Suite; am I remembering correctly?

I actually see this in the dictionary, but it doesn't work (either with windows or browser windows).

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Confirming since I've verified this did work in 1.5.x (and if for whatever reason we decided it wasn't going to work, the resolution would be WONTFIX anyway).

tell application "Camino"
	get the bounds of window 1
end tell

returns a set of window bounds on 1.5.x and returns "Camino got an error: NSCannotCreateScriptCommandError" on 1.6*pre.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

bleh, return :/

Comment 4

[Peter Jaros (:peeja)]

Attachment: Add bounds property

Ah, mea culpa.  I think perhaps when I deleted the "document" property "bounds" got caught in the crossfire.  Sure enough, it's missing from the sdef.  This patch puts it where it belongs.

Targeting for sr as it's a trivial patch.

Comment 5

[Chris Lawson (gone)]

Uhm...from the attachment:

+			<property name="bounds" code="pbnd" description="The bounding rectangle of the window." type="rectangle">
+				<cocoa key="boundsAsQDRect"/>
+			</property>
 			<!-- Rectangles do not appear to be properly supported by AS at this time and only cause Console warnings.
 			<property name="bounds" code="pbnd" description="The bounding rectangle of the window." type="rectangle">
 				<cocoa key="boundsAsQDRect"/>
 			</property> -->

Note the comment just below what you added. It appears someone -- probably Peter, as checked in by Ian -- decided this didn't work properly anyway :-p

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 303801 [details] [diff] [review]
Add bounds property

(In reply to comment #5)
> Uhm...from the attachment:
> 
> +                       <property name="bounds" code="pbnd" description="The
> bounding rectangle of the window." type="rectangle">
> +                               <cocoa key="boundsAsQDRect"/>
> +                       </property>
>                         <!-- Rectangles do not appear to be properly supported
> by AS at this time and only cause Console warnings.
>                         <property name="bounds" code="pbnd" description="The
> bounding rectangle of the window." type="rectangle">
>                                 <cocoa key="boundsAsQDRect"/>
>                         </property> -->
> 
> Note the comment just below what you added. It appears someone -- probably
> Peter, as checked in by Ian -- decided this didn't work properly anyway :-p

Well, it works fine on 10.3.9 and 10.5.2 (and it did/does in 1.5.x as well).  I suppose it could be/have been broken on 10.4, and ideally we should track down someone to test there.  However, r=ardissone on this as long you get your chicken-wrangler to check it in with only one copy of the bounds property definition ;)

Comment 7

[Peter Jaros (:peeja)]

Attachment: Mark II

I guess that's what I get for looking in Sdef Editor and not using a text editor.  I remember doing that now.  This is probably a 10.4 bug, since I remember seeing it in other apps.  I agree, we should find someone on 10.4 to do more testing.  I'm not sure there's much we can do about it though, besides support non-broken systems.

Anyhow, I made a new patch to make things easy.  This should do.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 303931 [details] [diff] [review]
Mark II

rs=pink

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the trunk and MOZILLA_1_8_BRANCH; may all your windows return their bounds henceforth.