417695 - Treeview headers should be painted with button in the middle of the header

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Ian Spence]

In some gtk engines, the first button and the last button are painted differently (usually with a highlight). This highlight can make the buttons look disconnected  Since gtk does not have some special way of painting each header, we actually need to add two more column headers and paint with the middle one.  The attached patch adds this.

Asking for review even though I know I should probably rename the local variables to something more descriptive

Comment 1

[Ian Spence]

Attachment: Paints with a treeview header button that is between two other buttons

Comment 2

[Reed Loden [:reed]]

Ian, want to go with this as-is or rename the variables?

Comment 3

[Reed Loden [:reed]]

Ian, either just added checkin-needed or attach an updated patch and add checkin-needed, please. :)

Comment 4

[Ian Spence]

I'll get a patch posted tonight :)

Comment 5

[Ian Spence]

Attachment: Updated to explain logic and have more descriptive variable names

Updated to make more sense to anyone reading the code

Comment 6

[Reed Loden [:reed]]

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.81; previous revision: 1.80
done

Comment 7

[Reed Loden [:reed]]

Backed this out to see if it's the cause of the Tp2 regression on Linux.

Comment 8

[Reed Loden [:reed]]

This wasn't it. I'll reland this soon.

Comment 9

[Reed Loden [:reed]]

Relanded.

Checking in widget/src/gtk2/gtk2drawing.c;
/cvsroot/mozilla/widget/src/gtk2/gtk2drawing.c,v  <--  gtk2drawing.c
new revision: 1.84; previous revision: 1.83
done