417703 - PatcherConfig doesn't use a product and version specific working directory

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Use a working dir based on product, version, and rc

Currently, PatcherConfig looks up configBumpDir and uses that as it's working directory. We use same value of /builds/config across a bunch of situations, so there's the potential for a collision if more than one build is running on a machine. This patch makes PatcherConfig do the same sort of thing as TinderConfig, Updates et al.

Actually noticed this when a nightly build went rm -rf /builds/config/* while I was running PatcherConfig. This patch won't help for that, but prompted me to notice that PatcherConfig is the odd one out.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Checking in PatcherConfig.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/PatcherConfig.pm,v  <--  PatcherConfig.pm
new revision: 1.16; previous revision: 1.15
done

Comment 2

[Robert Helmer [:rhelmer]]

Sorry, missed a spot; this needs to be done in BumpPatcherConfig as well.

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: [checked in] also use rc in BumpConfig

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 305809 [details] [diff] [review]
[checked in] also use rc in BumpConfig

Oopsie.

Comment 5

[Robert Helmer [:rhelmer]]

Comment on attachment 305809 [details] [diff] [review]
[checked in] also use rc in BumpConfig

Checking in Bootstrap/Step/PatcherConfig.pm;
/cvsroot/mozilla/tools/release/Bootstrap/Step/PatcherConfig.pm,v  <--  PatcherConfig.pm
new revision: 1.18; previous revision: 1.17
done