417715 - Uploading pictures to Ebay is not possible with Firefox 3 Beta 3

Status: VERIFIED FIXED

(Tech Evangelism Graveyard :: German, defect, P1)

Description

[Thorsten]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3

Since I upgraded to Firefox 3 Beta 3 it is not possible anymore to upload pictures to Ebay.

When you visit URL http://cgi5.ebay.de/ws/eBayISAPI.dll?EasyLister&keywords= and go to step 3 and try to upload a picture an error message appears.

At the moment I have to use IE, when I want to sell something on ebay, because Firefox is not working for this task. It is really frustrating !

Reproducible: Always

Steps to Reproduce:
1. Visit the URL http://cgi5.ebay.de/ws/eBayISAPI.dll?EasyLister&keywords=
2. Go to step 3 and click on button "Foto hinzufügen"
3. In the popup dialog search for a picture on your harddisc
4. When you click on "Foto hochladen" the error message appears



In Firefox 2 this functionality worked without problems.
Since I upgraded to Firefox 3 this is not working anymore and I have to use IE when I want to sell something on ebay.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can confirm this bug with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021504 Minefield/3.0b4pre ID:2008021504 but it doesn't happen under OS X.

The error message which comes up states that the selected image cannot be found on the computer. When the pop-up is opened I see following error within the Error Console:

Error: this.editor is null
Source File: chrome://global/content/bindings/textbox.xml
Line: 152

Comment 2

[Boris Zbarsky [:bzbarsky]]

Can someone hunt down a one-day regression range?

It happening on Windows but not Mac is just bizarre....

Comment 3

[Benjamin Smedberg]

Does this happen for any filename and any directory? If it's windows-specific I wonder if it's related to unicode file paths being converted to native at some point in the process (which is lossy).

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Testcase for file upload

The regression happens between the following two trunk nightly builds:

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007111404 Minefield/3.0b2pre ID:2007111404

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b2pre) Gecko/2007111505 Minefield/3.0b2pre ID:2007111505

I tried with several file types but without success.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Check-ins within this timeframe:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-11-14+0%3A00%3A00&maxdate=2007-11-15+10%3A00%3A00&cvsroot=%2Fcvsroot

Comment 6

[Boris Zbarsky [:bzbarsky]]

Bug 143220, perhaps?  The platform difference could be something in the site code...

The other option is bug 324397 (easy to test by flipping the pref back).

Those two are the only things in that range that look to me like they might affect this.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Flipping the pref back to 0 doesn't change anything for me. If we would have a test case that works under OS X I could try to debug. But bug 143220 sounds like a good candidate. Perhaps an issue in handling the path delimiters '/' or '\'? 

Comment 8

[Damon Sicore (:damons)]

Looking for an owner for this bug.  Anyone?

Comment 9

[Daniel Holbert [:dholbert]]

I can take a shot at it.

Comment 10

[Daniel Holbert [:dholbert]]

(In reply to comment #6)
> Bug 143220, perhaps? 

(In reply to comment #7)
> But bug 143220 sounds
> like a good candidate. 

Yup -- backing out the patch for bug 143220 fixes this bug on Windows Vista.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Daniel, is the page actually getting the value and doing something with it, perhaps?  If it _is_ calling that getter, what's the JavaScript stack look like when it does that?

Comment 12

[Daniel Holbert [:dholbert]]

As Boris suggested in Comment 6, the windows-specific aspect of this bug is in their JS code.

See this chunk from easylister_dlg_photos_e5511de.js, where "val" is the user-provided filename:
(whitespace added for readability) 

  if(!this.oGlobals.oClient.bMac &&
     !this.oGlobals.oClient.bLinux &&
     ( (val.lastIndexOf("\\")==-1) ||
       ((val.indexOf(':')!=1) && (val.indexOf('\\\\')!=0) )))


    this.parent.setErrMsg("FP001");
 else 
{
   this.enable(false);
   oPicForm.setAction(sMSAUrl);
   oPicForm.submit();
 }

The "setErrMsg" is what triggers the buggy state, whereas the "else" clause is what gives correct behavior.

The "if" conditions basically puts the following requirements on Windows paths, while placing no restraints on Mac/Linux paths:
  - Must have at least one '\' character
  - Must either contain ':' or start with \\

After the checkin of bug 143220, we only give the file's name, without any path information, so those conditions don't hold anymore.  So, that JS code will always fail on Windows platforms.

Comment 13

[Daniel Holbert [:dholbert]]

Redirecting to evangelism.  Ebay's script seems to assume we're giving them the full path to the file, and we no longer do that. (nor should we, per bug 143220)

Comment 14

[Damon Sicore (:damons)]

Thanks for driving this, Daniel.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

What is the normal procedure for such bugs? Will Ebay be informed about this issue? 

Comment 16

[Boris Zbarsky [:bzbarsky]]

The more people inform them, the better, generally...

Comment 17

[Bob Clary [:bc] (inactive)]

(In reply to comment #15)
> What is the normal procedure for such bugs? Will Ebay be informed about this
> issue? 
> 

There is no longer an official tech evangelism team and all contacts are made by members of the community. To paraphrase an old mozilla developer adage: "emails to deficient sites appreciated". If you want to make sure ebay knows about this, you should contact them and report back here.

I've cc'd some @ebay.com folks I found in bugzilla. Maybe they can report this to the appropriate people or give us some contacts.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I've also sent a message via the contact form to Ebay Germany, pointing to both bug reports.

Comment 19

[Thorsten]

Seems nothing is happening on this problem ?

Comment 20

[Boris Zbarsky [:bzbarsky]]

> Seems nothing is happening on this problem ?

It's a problem in Ebay's code: they were relying on a security hole, and that hole got fixed.  Please contact them if you want this to get resolved...

Comment 21

[Thorsten]

Well,
can't believe that. With FX2 it worked :-)
Why should it be an Ebay problem then.

If it works for FX2 and with FX3 not.

Comment 22

[Mike Shaver (:shaver emeritus)]

As bz said: "they were relying on a security hole, and that hole got fixed".  Telling us to re-open the security hole will not be productive; you should contact eBay if you can, and not further comment here about the specific change.  Thanks!

Comment 23

[sathish]

Notified to the team at ebay that owns this code. It's been either addressed already or being looked at now.

Thanks

Comment 24

[Daniel Veditz [:dveditz]]

Thorsten, dholbert: do either of you know if eBay has fixed their code yet? We'd like to take bug 143220 on the FF2 branch.

Comment 25

[Daniel Veditz [:dveditz]]

Brandon can upload photos to the _us_ site using FF3b5, does that mean it's fixed or did the German version use different code?

Comment 26

[Daniel Holbert [:dholbert]]

(In reply to comment #24)
> Thorsten, dholbert: do either of you know if eBay has fixed their code yet?
(In reply to comment #25)
> did the German version use different code?

I don't know -- in my analysis on this bug, I just worked with the zipped testcase that's attached here.  (I don't actually have an ebay account.)

Comment 27

[neeraj]

Yes it has been fixed by eBay.

Comment 28

[Thorsten]

Hello,
I reported that bug in the past and I just checked it with Firefox 3.0 RC1.

It works now.

So this bug can be closed !

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9) Gecko/2008051206 Firefox/3.0 ID:2008051206

Comment 30

[Daniel Veditz [:dveditz]]

Thanks for reporting back to us, and thanks to the ebay employees who helped fix the experience for FF3 users.