417782 - Switch search field to Command-Option-F

Status: VERIFIED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Stuart Morgan]

We've discussed this tangentially in a few places, but don't seem to have a bug about it: it's been suggested a number of times recently (and I agree at this point) that we should change to Command-Option-F for the search field. Last time we discussed this it was in the context of "Safari does it", but now it's both a defacto (Finder, Safari, Mail, iTunes, Address Book, Dictionary, ...) and explicit (the current HIG suggested keyboard commands list it as "Jump to the search field control.") OS standard.

I think we should make the call for 1.6 (which means 1.6b3, since it's a nib change).

We'll have to change Fill Form if we do it, but having OS consistency on a very common shortcut is, IMO, worth the churn.

Comment 2

[Mike Pinkerton (not reading bugmail)]

damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit damnit

yes.

Comment 3

[Stuart Morgan]

Alrighty. Let's make it happen then.

Comment 4

[Stuart Morgan]

Attachment: new nib, option 1

Option 1 is switching the shortcuts of "Search the Web" and "Fill Form". We'll still stomp the Spotlight service, but I don't think most people will care.

Comment 5

[Stuart Morgan]

Attachment: new nib, option 2

Option 2 is renaming "Fill Form" to "Auto-Fill Form" and giving it the Safari Command-Shift-A. If we have to change its shortcut anyway, there's something to be said for being consistent with Safari.

I'm attaching both because booting to Tiger to make these is annoying; I don't have a strong opinion as to which we should use. We should pick one (or some new, better option that I didn't think of) at the meeting.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #5)
> Option 2 is renaming "Fill Form" to "Auto-Fill Form" and giving it the Safari
> Command-Shift-A. If we have to change its shortcut anyway, there's something to
> be said for being consistent with Safari.

There's the small problem that we don't *auto*-fill; we manually fill by invoking that command (and then only the few things we can successfully match to the right form fields from Address Book).

Comment 7

[Stuart Morgan]

Safari calls it "AutoFill"; it's "auto" in the sense of "it automatically puts information about you in the right place (hopefully)".

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 303755 [details]
new nib, option 2

I much prefer the other option, since Safari also has auto-fill (bug 319792), and I'd like to prevent user confusion ("you have this 'autofill' menu item; why aren't you autofilling my info when the page loads?").

Comment 9

[Stuart Morgan]

Comment on attachment 303754 [details]
new nib, option 1

Option one got pink's sr in the meeting.

Comment 10

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.

Take your medicine, everyone! It may taste bad, but the doctor says it's good for you.

Comment 11

[Ryan Pavlik]

The help file still needs to be updated - Help -> Keyboard Shortcuts shows the old shortcut in 1.6b4.  Should I file this separately?

Comment 12

[Stuart Morgan]

The online help always refers to the latest released version, not to nightly builds or betas. It will be updated when 1.6 is released.

Comment 13

[j-paul.tmp]

With Camino 1.6, focus on the search field is got with cmd+option + F (french system).
But in the dedicated help page, it's still writen cmd + maj + F : a line to fix.
Thanks

Comment 14

[Stuart Morgan]

We'll fix the second entry there, thanks. In the future though, please report website problems like this as new bugs against the Product Site component rather than as comments in fixed bugs.