417794 - Find bar doesn't live-update with the find pasteboard (e.g, when using Command-E)

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: General, defect)

Description

[Stuart Morgan]

We should make sure that the Find bar stays more current with the search clipboard. Most importantly, if you have the find bar open and use Command-E on some selected text from the page, the bar should update.

Comment 1

[Stuart Morgan]

This can also happen if the find bar is open in multiple tabs.

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Conceptually, we'd want to have CHBrowserView's |NSFindPanelActionSetFindString:| case do something like 1) check and see if we have a (any?) FindBarController and then 2) call FBC's |findPasteboardString| (were it not private), right?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Or should CHBV send a notification when the find string changes, and FBC would then listen for the notification and call |findPasteboardString| itself?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Per discussion, comment 4 is what we should do here.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Partial fix, v0.5

This is a partial fix for this bug (which builds upon the patch in bug 608174).

It handles the case of Cmd-E in content (it specifically ignores Cmd-E in chrome, which is the subject of bug 490558).

It does not yet handle the case of typing something else in a Find Bar in another tab.  We need to determine at what point we should update the Find Pasteboard (on every keypress? on return-press? at some other point), and we need some way of preventing an infinite loop when updating everyone's search field string as a result of the notification.