417837 - Find Toolbar: [return key] to find next instance only works once per focus

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[[e-mail]]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en; rv:1.8.1.12pre) Gecko/20080118 Camino/1.6b2 (like Firefox/2.0.0.12pre)

Using the Find toolbar, typing a string highlights the first found instance of the string in the current page, as expected. Hitting the return/enter key while still focused in the Find input will, as expected, highlight and scroll to the next instance -- but only once. After that, it appears to do nothing (even though there are more instances down-page).

Clicking/focusing out of the toolbar and then back into the toolbar in effect re-starts the process: it works once, then ceases. 

Clicking the "Next" and "Previous" buttons work as expected.

Reproducible: Always

Steps to Reproduce:
1. Go to http://caminobrowser.org/ (as an example)
2. Type Cmd + F to bring up the Find Toolbar
3. Type "camino" in the toolbar.
Note the first instance of "camino" is now higlighted.
4. Type [enter]
Note the next instance of "camino" is now higlighted.
5. Type [enter] once more. Note that now the highlighted instance remains the same. Repeat ad infinitum.

6. Click anywhere else in the browser, then focus back in the Find input and type [enter].
Note that now the next instance is highlighted.
7. Subsequent [enter]s are ineffectual.
Actual Results:  
[enter] key only highlights next string instance once per focus event.

Expected Results:  
Each [enter] would highlight and scroll to the next instance of the string in the page.

Comment 1

[Stuart Morgan]

As currently designed, the expected behavior is actually that enter focuses content; under that model, the bug is actually 4, not 5 (i.e., enter should switch to content without focusing the next occurrence). Command-G (Find Again) is the way to do what you actually want.

There's a bug either way, but we should have some discussion about how we want this to work

Comment 2

[Stuart Morgan]

Actually, I take that back; we don't focus content. I was thinking of the code for handling focus on hide, I guess. So yes, this is a bug as originally described, and we should be keeping focus in the find bar on enter/return.

Comment 3

[Stuart Morgan]

Taking; there's a trivial patch that I can spin once I land the new findbar look.

Comment 4

[Stuart Morgan]

Attachment: fix

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 304279 [details] [diff] [review]
fix

sr=pink

Comment 6

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH.