417912 - GetCellDataAt callers that expect an error if no cell is found are wrong

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Bernd]

if GetCellDataAt does not find a table cell it will return  NS_TABLELAYOUT_CELL_NOT_FOUND 
this is not a severe error but a success code 

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/base/nsLayoutErrors.h&rev=1.11&mark=43-44#40

as a consequence 

NS_ENSURE_SUCCESS(rv, rv); calls afterward will not ensure that you have a cell 

you have to check also like the editor does

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/editor/libeditor/html/nsTableEditor.cpp&rev=1.76&mark=2868-2869#2856

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[Bernd]

if you don't get a cell back thats perfectly legimate, it says only that the arguments (row/column) are wrong

<table>
 <tr><td><td><td rowspan="3"></tr>
 <tr><td></tr>
 <tr><td><td></tr>
 </table>

if you now query the element at 1,1 you will hit a cellmap hole. I would say its not an "unexpected error"  but rather the args are invalid.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 303862 [details] [diff] [review]
patch

will file new patch per Bernd's comment.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch2

I'm sure we don't use nsHTMLEditor here

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> Created an attachment (id=303966) [details]
> patch2
> 
> I'm sure we don't use nsHTMLEditor here
> 

ah, misread you that was an example with editor :)

Comment 6

[alexander :surkov (:asurkov)]

Bernd, do you have any comments for the patch?

Comment 7

[Bernd]

Comment on attachment 303966 [details] [diff] [review]
patch2

no

Comment 8

[Bernd]

stop, a mochitest where you hit this code  would be cool

<table>
 <tr><td><td><td rowspan=3>
 <tr><td>
 <tr><td><td>
</table>

and then access the cell at row 1 and column 1

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch3

with mochitest

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306209 [details] [diff] [review]
patch3

a1.9=beltzner

Comment 11

[alexander :surkov (:asurkov)]

checked in

/cvsroot/mozilla/accessible/src/html/nsHTMLTableAccessible.cpp,v  <--  nsHTMLTableAccessible.cpp
new revision: 1.61; previous revision: 1.60
done
Checking in accessible/tests/mochitest/test_nsIAccessibleTable_2.html;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessibleTable_2.html,v  <--  test_nsIAccessibleTable_2.html
new revision: 1.2; previous revision: 1.1
done