417961 - ctrl-z in content window can undo last bookmarks action

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Andrew Schultz]

Attachment: only activate controller with context menu

Because the bookmarks context menu (for the bookmarks menu) is always active, it will happily attempt to undo the last bookmarks transaction whenever you hit ctrl-z in the content window unless you're focused on a text input.  One thing to do here is to give the BookmarksMenuController its own list of commands it supports via supportsCommand, rather than using BookmarksController.supportsCommand.  I can do that if it sounds reasonable.  But the more important thing is to do what I've attached, which makes BookmarksMenuController only active when the context menu is active.

Comment 1

[[e-mail]]

Comment on attachment 303758 [details] [diff] [review]
only activate controller with context menu

I wouldn't mess around with the controllers, simply allowing only the cmd_bm_ commands in supportsCommand sounds fine to me.

Comment 2

[Andrew Schultz]

Attachment: explicitly list supported commands

expandfolder is obviously not supported.

...so what's so scary about controllers?