Closed Bug 418058 Opened 17 years ago Closed 16 years ago

Add tooltip to X button in unifinder

Categories

(Calendar :: Calendar Frontend, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mozilla, Assigned: sipaq)

Details

Attachments

(1 file)

As discussed in mozilla.dev.apps.calendar the X button that closes the Unifinder should at least get a tooltip to tell users what it does. Not sure what the best text would be, perhaps "Close event list".
Attached patch Patch v1Splinter Review
The patch is pretty straight-forward. However, I would like to get feedback from Christian on this regarding the wording of the tooltip-text.
Attachment #303876 - Flags: ui-review?(christian.jansen)
Attachment #303876 - Flags: review?(philipp)
Status: NEW → ASSIGNED
Target Milestone: --- → 0.9
Comment on attachment 303876 [details] [diff] [review]
Patch v1

I think we should not add extra spaces between entities, since this theoretically has to be done everytime a longer entity is added. I can live with the spaces though.

r=philipp
Attachment #303876 - Flags: review?(philipp) → review+
Severity: normal → trivial
Component: General → Calendar Views
QA Contact: general → views
Whiteboard: [checkin needed after 0.8]
Version: Mozilla 1.8 Branch → unspecified
Whiteboard: [checkin needed after 0.8] → [checkin-needed after 0.8]
Comment on attachment 303876 [details] [diff] [review]
Patch v1

r=christian. Thanks for the patch.
Attachment #303876 - Flags: ui-review?(christian.jansen) → ui-review+
Patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.8]
Checked with latest build (Lightning 2008041318/Sunbird 20080413) -> task is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: