Closed Bug 418120 Opened 13 years ago Closed 13 years ago

Double click on bookmark item in places library does not open in main window

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 beta4

People

(Reporter: luke.iliffe, Assigned: mano)

References

Details

(Keywords: polish, regression)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021704 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021704 Minefield/3.0b4pre

When double clicking on a bookmark in the places library it does not open in the main window

Reproducible: Always

Steps to Reproduce:
1. Open the places library
2. Double click on a bookmark item
3.
Actual Results:  
nothing happens. Nothing in the error console.

Expected Results:  
URL open in the main window.

Regression range:
Works  08-02-16 21:57 (2008021622)
Broken 08-02-16 23:09 (2008021623)
Fallout from the drag & drop bug 405198?
Where is the Places Library?
confirmed: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021704 Firefox/3.0.0.0 ID:2008021704

Aakash: 'Bookmarks/Show all ...'
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
OS: Windows Vista → All
Version: unspecified → Trunk
Range from comment 0

Checkins to module PhoenixTinderbox between 2008-02-16 21:57 and 2008-02-16 23:08 :
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1203227820&maxdate=1203232139

--> bug 405198
Blocks: 405198
Flags: blocking-firefox3?
Assignee: nobody → mano
Flags: blocking-firefox3? → blocking-firefox3+
Keywords: polish
Target Milestone: --- → Firefox 3 beta4
Comment on attachment 304450 [details] [diff] [review]
patch

would be cleaner to add a new method instead of cramming into the attribute, but up to you. r=me.
Attachment #304450 - Flags: review?(dietrich) → review+
I prefer not to bloat the file with more one-liner functions.
Target Milestone: Firefox 3 beta4 → ---
mozilla/browser/components/places/content/places.js 1.129
mozilla/browser/components/places/content/places.xul 1.108
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta4
Confirmed, now working on Windows Vista HP

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022009 Minefield/3.0b4pre Firefox/3.0 ID:2008022009
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022104 Minefield/3.0b4pre ID:2008022104

No idea, if this is already in Litmus. Lets ask for it anyway.
Status: RESOLVED → VERIFIED
Flags: in-litmus?
definitely in Litmus already
Flags: in-litmus? → in-litmus+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.