418120 - Double click on bookmark item in places library does not open in main window

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Luke Iliffe (Harlequin99)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021704 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008021704 Minefield/3.0b4pre

When double clicking on a bookmark in the places library it does not open in the main window

Reproducible: Always

Steps to Reproduce:
1. Open the places library
2. Double click on a bookmark item
3.
Actual Results:  
nothing happens. Nothing in the error console.

Expected Results:  
URL open in the main window.

Regression range:
Works  08-02-16 21:57 (2008021622)
Broken 08-02-16 23:09 (2008021623)
Fallout from the drag & drop bug 405198?

Comment 1

[Aakash Patel]

Where is the Places Library?

Comment 2

[(mostly gone) XtC4UaLL [:xtc4uall]]

confirmed: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008021704 Firefox/3.0.0.0 ID:2008021704

Aakash: 'Bookmarks/Show all ...'

Comment 3

[Steve England [:stevee]]

Range from comment 0

Checkins to module PhoenixTinderbox between 2008-02-16 21:57 and 2008-02-16 23:08 :
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1203227820&maxdate=1203232139

--> bug 405198

Comment 4

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

Attachment: patch

Comment 5

[Dietrich Ayala (:dietrich)]

Comment on attachment 304450 [details] [diff] [review]
patch

would be cleaner to add a new method instead of cramming into the attribute, but up to you. r=me.

Comment 6

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

I prefer not to bloat the file with more one-liner functions.

Comment 7

[Mano (::mano, needinfo? for any questions; not reading general bugmail)]

mozilla/browser/components/places/content/places.js 1.129
mozilla/browser/components/places/content/places.xul 1.108

Comment 8

[Jim Jeffery not reading bug-mail 1/2/11]

Confirmed, now working on Windows Vista HP

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b4pre) Gecko/2008022009 Minefield/3.0b4pre Firefox/3.0 ID:2008022009

Comment 9

[Henrik Skupin (:whimboo) [⌚️UTC+2] (away 01/15 - 01/31)]

Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008022104 Minefield/3.0b4pre ID:2008022104

No idea, if this is already in Litmus. Lets ask for it anyway.

Comment 10

[Tracy Walker [:tracy]]

definitely in Litmus already

Comment 11

[Gervase Markham [:gerv] (not reading bugmail)]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv