418126 - Add runtime requirement support for Linux (show alert when gtk is too old)

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Reed Loden [:reed]]

We need a way to inform users who try the Linux binaries for Firefox 3 that GTK+ versions below 2.10 aren't supported instead of just crashing on the user. The same may hold true for other changes in runtime requirements. This will require a new string be added, so late-l10n.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

FWIW, Unless things have changed, mozilla.org isn't releasing binary versions of Firefox 3 final (which would make this WONTFIX unless you care about doing this for nightlies?).  Mike Connor blogged about this a while ago.  http://steelgryphon.com/blog/?p=96

Comment 2

[Michael Ventnor]

The logical place I can see to put a dialog like this is nsNativeAppSupportUnix.cpp, but I can't load the string service there so I can't get a localized string. Is there any other point in the program before we need a GTK 2.10 feature but after we've loaded XPCOM?

Comment 3

[Mike Connor [:mconnor]]

We should fix this.  It looks like we're still going to ship our own builds, that proposal never really went far, unfortunately.  We've still managed to improve a lot about Firefox on Linux, but that was largely based on volunteers and some of our devs, rather than the distros taking over maintenance and advancing the progress.

We should fix this bug, though I'm ok without a localized string...

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Yes, we should definitely fix this -- even a simple dialog using core X stuff would be fine, even without a localized string.  Maybe a URL inside it (unclickable) where we can provide localized information.

Comment 5

[Michael Ventnor]

Attachment: Patch

At this point we can't get any XPCOM services so a translatable string is impossible, but I tried my best to make the overall message as easy to decipher as possible.

Comment 6

[Michael Ventnor]

Toolkit-only, no need for sr, and blocking, so no need for approval. Wonderful! :-)

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 304375 [details] [diff] [review]
Patch


>+#define MIN_GTK_MAJOR_VERSION 2
>+#define MIN_GTK_MINOR_VERSION 10
>+#define UNSUPPORTED_GTK_MSG "We're sorry, this application requires a version of the GTK library that is not installed on your computer.\n\n\
>+You have GTK %d.%d.\nThis application requires GTK %d.%d.\n\n\
>+Please upgrade your GTK library if you wish to use this application."

s/GTK/GTK+/g

And "This application requires ... or newer" please?

Comment 8

[Michael Ventnor]

Attachment: Slightly better string

Comment 9

[Reed Loden [:reed]]

Checking in toolkit/xre/nsNativeAppSupportUnix.cpp;
/cvsroot/mozilla/toolkit/xre/nsNativeAppSupportUnix.cpp,v  <--  nsNativeAppSupportUnix.cpp
new revision: 1.5; previous revision: 1.4
done

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Out of curiosity, is there a particular reason why you didn't use gtk_check_version?

Comment 11

[Michael Ventnor]

IIRC, gtk_check_version didn't work as expected. I can't remember the exact reason though.

Comment 12

[Reed Loden [:reed]]

This will become WONTFIX'd by bug 418885.