Closed
Bug 418251
Opened 16 years ago
Closed 16 years ago
TaskMode: Categories toolbar-button popup menu are not sorted locally dependent
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: berend.cornelius09, Assigned: berend.cornelius09)
References
Details
(Keywords: regression)
Attachments
(1 file, 2 obsolete files)
2.88 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: =================== - add two categories in the preference/categories dialog. One of the categories should contain a locale - specifice special character: E.G. for germany:"Z-Category" and "Ü-Category" - Switch to task-mode and select a task - Open the menu in the category-toolbar-button. RESULT: ======= The category with the special character is not correctly sorted in and will turn up in the end of the list. EXPECTED RESULT: ================ the category with the special character should be correctly sorted in. REPRODUCIBLE: ============= - always
Flags: blocking-calendar0.8?
Assignee | ||
Comment 1•16 years ago
|
||
This is a followup bug of bug 327780 Need to sort out what sort of toolbar UI to offer for Lightning, where I partly overwrote functioality from patch bug 321010.
Attachment #304042 -
Flags: review?
Assignee | ||
Comment 2•16 years ago
|
||
This is a followup bug of bug 327780 Need to sort out what sort of toolbar UI to offer for Lightning, where I partly overwrote functioality from patch bug 321010.
Attachment #304043 -
Flags: review?(philipp)
Assignee | ||
Comment 3•16 years ago
|
||
Comment on attachment 304042 [details] [diff] [review] patch v. #1 (again) attached patch twice...
Attachment #304042 -
Flags: review?
Comment 4•16 years ago
|
||
Berend, I think you can get rid of |var categoriesString = getLocalizedPref("calendar.categories.names", "");|, and adjust the comment about the empty string and split.
Updated•16 years ago
|
Attachment #304042 -
Attachment is obsolete: true
Comment 5•16 years ago
|
||
You should also replace following in setCategory(...): setItemProperty(aItem, "CATEGORIES", category); with setItemProperty(item, "CATEGORIES", categoriesArrayToString([category]));
Comment 6•16 years ago
|
||
I don't think that this really blocks the release. We will take the patch of course if it arrives in time.
Status: NEW → ASSIGNED
Flags: blocking-calendar0.8? → blocking-calendar0.8-
Comment 7•16 years ago
|
||
This regressed Bug 321010 according to Bug 327780 Comment #44.
Blocks: 321010
Keywords: regression
Assignee | ||
Comment 8•16 years ago
|
||
mschroeder, thank you for your hints.
Attachment #304043 -
Attachment is obsolete: true
Attachment #304215 -
Flags: review?(philipp)
Attachment #304043 -
Flags: review?(philipp)
Comment 9•16 years ago
|
||
Comment on attachment 304215 [details] [diff] [review] patch v. #2 Looks good, r=philipp
Attachment #304215 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 10•16 years ago
|
||
patch v. #2 checked in on trunk and MOZILLA_1_8_BRANCH
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Target Milestone: --- → 0.8
Comment 11•16 years ago
|
||
checked in nightly build 2008022020 -> task is fixed and verified.
Status: RESOLVED → VERIFIED
Updated•16 years ago
|
Flags: blocking-calendar0.8-
You need to log in
before you can comment on or make changes to this bug.
Description
•