Closed Bug 418296 Opened 13 years ago Closed 13 years ago

unifinder event list sort key caching speed improvement

Categories

(Calendar :: Calendar Views, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gekacheka, Assigned: gekacheka)

References

Details

(Keywords: perf)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3) Gecko/2008020514 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.13pre) Gecko/20080215 Calendar/0.8pre

Sort speed of unifinder event list can be improved by eliminating accesses of calEvent objects during sort.  Basic approach is to sort (key,item) pairs rather than events, so unlike current cache, no longer have to access the calEvent uid or any other field of the calEvent.

On ~900 element calendar such as 
http://ical.mac.com/ebony.ivory/Musicians'%20Birthdays.ics
the sort time is improved from about 4-5 sec to about 1+ sec on w2k.

Reproducible: Always

Steps to Reproduce:
1. subscribe to above link
2. click on an event list column header to sort event list
Actual Results:  
takes 4-5 sec.

Expected Results:  
takes 1 sec (approx 3-4x faster)
Keywords: perf
Version: unspecified → Trunk
(patch -l -p 1 -i file.patch)

With this patch, the unifinder event list sorts 3-4 times faster.
See comment 0.
Assignee: nobody → gekacheka
Status: NEW → ASSIGNED
Attachment #304094 - Flags: review?(philipp)
Blocks: 415442
Comment on attachment 304094 [details] [diff] [review]
patch v1: sort (key,item) pairs

Looks good, checking in...
Attachment #304094 - Flags: review?(philipp) → review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
OS: Windows 2000 → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 0.8
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.