418371 - implement the rest of methods of nsIAccessibleTable on xul:listbox

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

implement the rest of methods of nsIAccessibleTable on xul:listbox

Comment 1

[alexander :surkov (:asurkov)]

Attachment: wip

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 3

[Evan Yan]

Comment on attachment 306262 [details] [diff] [review]
patch

>+  nsCOMPtr<nsIDOMXULMultiSelectControlElement> control =
>+    do_QueryInterface(mDOMNode);
>+  NS_ASSERTION(control,
>+               "Doesn't implement nsIDOMXULMultiSelectControlElement.");

If it's a single selection list, could it still be QI to multiSelectContrlEl?

We can implement GetColumnHeader/GetRowHeader as well, and add testcases for <listheader>.

Comment 4

[alexander :surkov (:asurkov)]

(In reply to comment #3)
> (From update of attachment 306262 [details] [diff] [review])
> >+  nsCOMPtr<nsIDOMXULMultiSelectControlElement> control =
> >+    do_QueryInterface(mDOMNode);
> >+  NS_ASSERTION(control,
> >+               "Doesn't implement nsIDOMXULMultiSelectControlElement.");
> 
> If it's a single selection list, could it still be QI to multiSelectContrlEl?

It's implemented by XBL, so it's exposed always.

> We can implement GetColumnHeader/GetRowHeader as well, and add testcases for
> <listheader>.
> 

It would require a lot additional code because header should implement nsIAccessibleTable like header of xul:tree does. I like to deal with this in another bug.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306262 [details] [diff] [review]
patch

a1.9=beltzner

Comment 6

[alexander :surkov (:asurkov)]

checked in

/cvsroot/mozilla/accessible/src/base/nsAccessibilityAtomList.h,v  <--  nsAccessibilityAtomList.h
new revision: 1.87; previous revision: 1.86
done
Checking in accessible/src/xul/nsXULSelectAccessible.cpp;
/cvsroot/mozilla/accessible/src/xul/nsXULSelectAccessible.cpp,v  <--  nsXULSelectAccessible.cpp
new revision: 1.56; previous revision: 1.55
done
Checking in accessible/tests/mochitest/Makefile.in;
/cvsroot/mozilla/accessible/tests/mochitest/Makefile.in,v  <--  Makefile.in
new revision: 1.6; previous revision: 1.5
done
RCS file: /cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessibleTable_listboxes.xul,v
done
Checking in accessible/tests/mochitest/test_nsIAccessibleTable_listboxes.xul;
/cvsroot/mozilla/accessible/tests/mochitest/test_nsIAccessibleTable_listboxes.xul,v  <--  test_nsIAccessibleTable_listboxes.xul
initial revision: 1.1
done