418391 - Local XHTML does not load (considered invalid) if a non-existent CSS file is specified.

Status: VERIFIED FIXED

(Core :: XML, defect)

Description

[[:Aleksej]]

Attachment: Testcase: a valid XHTML with a CSS specified using <link>.

Mozilla/5.0 (X11; U; Linux i686 (x86_64); eo; rv:1.9b4pre) Gecko/2008021804 Minefield/3.0b4pre
Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b4pre) Gecko/2008021902 SeaMonkey/2.0a1pre

Steps to reproduce:
1. Have a valid XHTML document with a CSS file specified using the <link> attribute (see the attachment).
2. Try loading it from disk (the bug does not show up through HTTP):
 a) When the CSS file does exist.
 b) When the CSS file does not exist.

Actual results:


2a: WFM


2b:

XML Parsing Error: 
Location: file:///dev/shm/02/test.xhtml
Line Number 6, Column 71:	<link href="style.css" rel="stylesheet" type="text/css" media="all"/>
-----------------------------------------------------------------------------^


Regression range:

Fx 2007111804…2007111904
SM 2007111902…2007112002

→ bug 401613

See also: bug 404419.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Like so?

Comment 2

[Mats Palmgren (inactive)]

Attachment: Screenshot of the error message

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 304296 [details] [diff] [review]
Like so?

I don't think the CSSLoader is the right place to be doing this.  We should either do it like bug 404419 (CSS loading errors really should not be fatal to XML parsing) or finally fix that file channel bug so they won't throw from AsyncOpen.  Or both!

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Would it make sense to land the current patch for now and do the AsyncOpen thing after we've branched for FF3. It seems scary to fix that this close to release.

Or ideal would be to do what Boris says in comment 3. Mats would you be able to write up such a patch?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Forgot to say:

Don't think this is a blocker given that local files are rare, XHTML is rare, and failed CSS is rare, and having all three happen at the same time seems very very rare.

Comment 7

[Christophe Jacquet]

I'm the original reporter of bug #422735 that has just been marked as a duplicate of this one.

It seems that this bug does not impact local files only, but also XHTML documents stored in strings, and then parsed with DOMParser::parseFromString().

Therefore it will probably break some online apps, such as the LiveRC tool on Wikipedia <http://fr.wikipedia.org/wiki/Utilisateur:EDUCA33E/LiveRC/Documentation>. Indeed, LiveRC tries to parse an XHTML document contained in a string. This works fine in Firefox 2, but fails in Firefox 3b4. I think that this issue should be fixed in Firefox 3.

Comment 8

[Mats Palmgren (inactive)]

(In reply to comment #3)
> I don't think the CSSLoader is the right place to be doing this.

The CSSLoader part just adds a warning to the Error Console.
The fix is in nsStyleLinkElement.

(In reply to comment #4)
> Mats would you be able to write up such a patch?

Probably not, since I think my patch does it "like bug 404419" so I don't
understand what Boris is asking for...

Comment 9

[Boris Zbarsky [:bzbarsky]]

> The fix is in nsStyleLinkElement.

Ah, indeed.  I'm OK with that.  I don't think we want the CSSLoader change.

Comment 10

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Ok, without the warning message then...

Comment 11

[Mats Palmgren (inactive)]

Attachment: mochitest (needs file: support from bug 424484 first)

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 311454 [details] [diff] [review]
Patch rev. 2

Please make sure to file a followup bug (dependent on the file:// protocol thing) to remove this once we fix the protocol handler.

Comment 13

[Mats Palmgren (inactive)]

Attachment: mochitest (needs file: support from bug 424484 first)

Comment 14

[Mats Palmgren (inactive)]

(In reply to comment #12)
Filed bug 424880

Comment 15

[Mats Palmgren (inactive)]

mozilla/content/base/src/nsStyleLinkElement.cpp 	1.48 

-> FIXED

Comment 17

[[:Aleksej]]

Verified fixed with Mozilla/5.0 (X11; U; Linux i686; eo; rv:1.9pre) Gecko/2008042304 Minefield/3.0pre.