418469 - "Open all in tabs" under Smart Bookmarks > Recent Tags causes assertion failure.

Status: RESOLVED DUPLICATE of bug 400109

(Firefox :: Bookmarks & History, defect)

Description

[Brian Brennan]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

In the "Recent Tags" smart bookmark folder in the bookmarks toolbar, clicking on the "open all in tabs" option in the menu causes an assertion failure.

Reproducible: Always

Steps to Reproduce:
1. Click on the "Smart Bookmarks" link in the bookmarks toolbar
2. Go to a set of recent tags that has more than one site
3. Click on the "Open all in tabs" option.
Actual Results:  
A popup with "Assertion Failed" comes up.

Expected Results:  
All of my recent tags should have opened in tabs.

Comment 1

[Carsten Book [:Tomcat]]

note, the assertions are:

ASSERT: Node QI Failed
Stack Trace: 
0:QI_node([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)],nsINavHistoryQueryResultNode)
1:asQuery([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)])
2:PU_nodeIsReadOnly([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)])
3:PC_isCommandEnabled(placesCmd_sortBy:name)
4:isCommandEnabled(placesCmd_sortBy:name)
5:updatePlacesCommand(placesCmd_sortBy:name)
6:goUpdatePlacesCommands()
7:oncommandupdate([object Event @ 0x10e9868 (native @ 0x6395ef8)])


and

ASSERT: Node QI Failed
Stack Trace: 
0:QI_node([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)],nsINavHistoryQueryResultNode)
1:asQuery([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)])
2:([xpconnect wrapped (nsISupports, nsINavHistoryResultNode, nsINavHistoryContainerResultNode) @ 0x62e3b80 (native @ 0x62dacb0)])
3:PC__hasRemovableSelection(true)
4:PC_isCommandEnabled(placesCmd_moveBookmarks)
5:isCommandEnabled(placesCmd_moveBookmarks)
6:updatePlacesCommand(placesCmd_moveBookmarks)
7:goUpdatePlacesCommands()
8:oncommandupdate([object Event @ 0x6151e68 (native @ 0x6291cb8)]

Comment 2

[Carsten Book [:Tomcat]]

i think its maybe a dupe of bug 400109 looking at the assertions

Comment 3

[Brian Brennan]

The assertions that I get are different:

Here are the contents of the assertion failed popup:

ASSERT: Node QI Failed
Stack Trace:
0:QI_node([xpconnect wrapped (nslSupports, nslNavHistoryResultNode, nslNavHistoryContainerResultNode)], nslNavHistoryQueryResultNode)
1:asQuery([xpconnect wrapped (nslSupports,nslNavHistoryResultNode, nslNavHistoryContainerResultNode)])
2:PU_getURLSForContainerNode([xpconnect wrapped (nslSupports, nslNavHistoryResultNode, nslNavHistoryContainerResultNode)])
3.PU_openContainerInTabs([xpconnect wrapped (nslSupports, nslNavHistoryResultNode, nslNavHistoryContainerResultNode)], [object XULCommandEvent])
4.oncommand([objectXULCommandEvent])

Comment 4

[Ondrej Brablc]

(In reply to comment #2)
> i think its maybe a dupe of bug 400109 looking at the assertions

I think it is a duplicate of bug 400109, or at least this will hopefully be fixed by my patch for bug 385245 (I'm changing the result type of tag nodes). At least I was not able to reproduce this bug on Windows with my patch.
 

Comment 5

[Marco Bonardo [:mak]]

yes i also think this has the same cause of Bug 400109, the fact that is WFM with sidebar patch confirm that

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv