418524 - label of "Download activity summary in the status bar" with one download should be "1" not "One"

Status: RESOLVED FIXED

(Toolkit :: Downloads API, enhancement)

Description

[Nicolas Mandil (:NicolasWeb)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9b3) Gecko/2008020511 Firefox/3.0b3

Using "1" instead of "One" is easier to catch by eyes.
It's more logical because after it's labelled "2", "3", ...

Reproducible: Always

Steps to Reproduce:
1.download one file
2.download 2 files
3.
Actual Results:  
"One Download ..."
"2 Downloads ..."

Expected Results:  
"1 Download ..."
"2 Downloads ..."

this is liked with the bug 402278. Maybe it should be temporarly reopen.

Comment 1

[Nicolas Mandil (:NicolasWeb)]

Attachment: Actual behavior

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

We shouldn't reopen bug 402278 just to address this, but I'll confirm it as an enhancement request.

See https://bugzilla.mozilla.org/show_bug.cgi?id=402278#c19 and https://bugzilla.mozilla.org/show_bug.cgi?id=402278#c21.

Comment 3

[Shawn Wilsher :sdwilsh]

note: the code branching for this might not be worth the feature.

Comment 4

[Jesse Ruderman]

I agree with Nicolas.  The change from "2" to "One" grabs my attention unnecessarily, and makes me reparse the sentence.

Comment 5

[Nicolas Mandil (:NicolasWeb)]

(In reply to comment #2) 
> See https://bugzilla.mozilla.org/show_bug.cgi?id=402278#c19 and
> https://bugzilla.mozilla.org/show_bug.cgi?id=402278#c21.
OK, I've read this.
From a user and practical point of view, I'm sure we should use "1" and not "One". It's easier to understand. Fx should to be well polished : I think that we aren't writing an essay. Rules are rules only if they are applied in they context.
Here, Fx is counting numbers, and doing operations with them. 2 result of 1+1 download. So in that case "One" is inconsistant, because from a user point of view, you can't add to words to produce a number.

If you agree, as this is a Fx3 new feature, maybe we should flag it to "blocking Fx3 ?".

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Not blocking, but wanted. I agree with Shawn that less code branching better.

Comment 7

[Srirang G Doddihal (Brahmana)]

Attachment: With Changes to browser.properties file

I changed the browser.properties file and it appears to give the desired results. Is the acceptable?

Comment 8

[Srirang G Doddihal (Brahmana)]

Attachment: patch v0.1

Talked to sdwilsh and just the string change is sufficient. The second attached shows screen shots of this string change serving the purpose.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 359063 [details] [diff] [review]
patch v0.1

You should change the entity name to notify localizers of this change. r=me with that.

Comment 10

[Srirang G Doddihal (Brahmana)]

Attachment: patch v0.2 - New entity name and corresponding code change

Changed the entity names so that the localizers notice the change. Patch contains changes to both files : browser.properties and browser.js

This has r=gavin. So checkin-needed.

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 359222 [details] [diff] [review]
patch v0.2 - New entity name and corresponding code change

> # examples: One active download (2 minutes remaining); 11 paused downloads

That l10n note is incorrect.

>+activeDownloadsStr=1 active download (#2);#1 active downloads (#2)

I don't think that's a proper name for a string.

Comment 12

[Shawn Wilsher :sdwilsh]

generally we just append a number to the end of the string when we change it.  That's what you should do here as well.  Be sure to update the localization note too.

Comment 13

[Srirang G Doddihal (Brahmana)]

Attachment: patch v0.2

Addresses the comments.

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 359466 [details] [diff] [review]
patch v0.2

I don't really see a problem with appending "Str", fwiw.

Comment 15

[Srirang G Doddihal (Brahmana)]

Attachment: patch-v1.0

This patch somehow missed checkin the previous time. Updated the patch for current tree. The changes are the same.

Comment 16

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/7db1b9d406ef