Closed
Bug 418613
Opened 17 years ago
Closed 17 years ago
MOZ_DEBUG_SYMBOLS clobbers optimize flags, LDFLAGS
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
()
Details
Attachments
(1 file)
|
1.70 KB,
patch
|
benjamin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Ouch. We use this on fx-win32-tbox. I think this is for historical reasons.
|
Assignee | |
Comment 1•17 years ago
|
||
At least the optimize flags bit isn't terrible, since it uses -O1 which we're already using, but it's still wrong.
|
|
Assignee | |
Comment 2•17 years ago
|
||
Remember those awesome VC8 compiler flags? Yeah, we're not using them in nightly builds because of this. Patch coming up.
Blocks: 368854
Flags: blocking1.9?
|
|
Assignee | |
Comment 3•17 years ago
|
||
This patch trims down the options MOZ_DEBUG_SYMBOLS sets, and appends them instead of overriding them.
Attachment #304730 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 4•17 years ago
|
||
I verified that I still get debug symbols, but also the linker flags like -SAFESEH are passed along.
|
||
Updated•17 years ago
|
Attachment #304730 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Updated•17 years ago
|
Attachment #304730 -
Flags: approval1.9?
|
||
Comment 5•17 years ago
|
||
Comment on attachment 304730 [details] [diff] [review]
don't override optimize flags or ldflags
a=beltzner for 1.9
Attachment #304730 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9+
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•