Closed Bug 418754 Opened 13 years ago Closed 13 years ago

Clustering doesn't work for Thai

Categories

(Core :: Graphics, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: roc, Assigned: roc)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
See https://bugzilla.mozilla.org/show_bug.cgi?id=157546#c45 and https://bugzilla.mozilla.org/show_bug.cgi?id=157546#c46.

The fix is pretty simple, we're applying the SetSimpleGlyph optimization to characters that are not the start of clusters. This is wrong because simple-glyphs are always cluster starts.

John, I believe you worked on this code so you should be able to do the review.

This should block because clusters are pretty much broken on Mac and the fix is trivial.
Flags: blocking1.9?
Attachment #304645 - Flags: review?(jdaggett)
Summary: Clustering don't work for Thai → Clustering doesn't work for Thai
Whiteboard: [needs review]
Comment on attachment 304645 [details] [diff] [review]
fix

Looks good.
Attachment #304645 - Flags: review?(jdaggett) → review+
Comment on attachment 304645 [details] [diff] [review]
fix

Very low-risk fix for major intl Mac bug --- clustering mostly broken.

This will be tested by the tests in bug 157546.
Attachment #304645 - Flags: approval1.9?
Comment on attachment 304645 [details] [diff] [review]
fix

a=beltzner for 1.9
Attachment #304645 - Flags: approval1.9? → approval1.9+
checked in
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: blocking1.9?
Resolution: --- → FIXED
Whiteboard: [needs review]
I landed 157546 which contains tests which test this code (amongst other things).
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.