418754 - Clustering doesn't work for Thai

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

See https://bugzilla.mozilla.org/show_bug.cgi?id=157546#c45 and https://bugzilla.mozilla.org/show_bug.cgi?id=157546#c46.

The fix is pretty simple, we're applying the SetSimpleGlyph optimization to characters that are not the start of clusters. This is wrong because simple-glyphs are always cluster starts.

John, I believe you worked on this code so you should be able to do the review.

This should block because clusters are pretty much broken on Mac and the fix is trivial.

Comment 1

[John Daggett (:jtd)]

Comment on attachment 304645 [details] [diff] [review]
fix

Looks good.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 304645 [details] [diff] [review]
fix

Very low-risk fix for major intl Mac bug --- clustering mostly broken.

This will be tested by the tests in bug 157546.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 304645 [details] [diff] [review]
fix

a=beltzner for 1.9

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I landed 157546 which contains tests which test this code (amongst other things).