418756 - [FIX]Radios and checkboxes differ in how .checked and the "checked" attribute interact

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Jesse Ruderman]

Attachment: testcase

The radio button ends up being checked but the checkbox does not.  This seems inconsistent, but I'm not sure it's a bug.  I think refdyn would be happier if they both ended up unchecked, fwiw.

Noticed by refdyn + layout/reftests/bugs/120834-2h.html.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Radios do radio group stuff, unlike checkboxes.  So their checked behavior is quite radically different.

Comment 2

[Boris Zbarsky [:bzbarsky]]

In particular, when a radio is added to the DOM, its "checked has been set" value is set to the value of the other radios in the group by nsHTMLInputElement::AddedToRadioGroup.  If there are no others, it's reset to false.

It would probably makes sense to not reset it if there are no other radios in the group...

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to that effect

Jesse, would you be willing to write up some tests for this behavior, including when there are multiple radios, etc?

In fact, it would be good to have a reasonably exhaustive test suite for radio behavior...

Comment 4

[Jesse Ruderman]

I don't think I understand this well enough to make an exhaustive set of tests.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Well, I dunno that anyone does, to be honest.  I guess I can try to write tests based on what the code is doing...

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 304658 [details] [diff] [review]
Patch to that effect

Could we get some mochitests here too?

Comment 7

[Boris Zbarsky [:bzbarsky]]

In June, yes.

I figure this is post-1.9 stuff at this point.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Now with tests

Comment 9

[Boris Zbarsky [:bzbarsky]]

Fixed, with a few more tweaks to the tests.