Closed Bug 418871 Opened 15 years ago Closed 13 years ago

Remove unused parts from imgIContainer.idl

Categories

(Core :: ImageLib, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9.2a1

People

(Reporter: alfredkayser, Assigned: alfredkayser)

References

Details

(Keywords: memory-footprint)

Attachments

(1 file)

in imgIContainer.idl:
    Clear(): is not used and defined as NOT_IMPLEMENTED
    RemoveFrame(): is not used and defined as NOT_IMPLEMENTED
    GetAnimationMode(): Not used anywhere.
Blocks: 430829
Duplicate of this bug: 385960
Simple code cleanup.

Note: nsJPEGDecoder used Clear(), but it was NOT_IMPLEMENTED,
it didn't do what was expected of it. (note, this is only used for animated jpeg streams...)
Attachment #370618 - Flags: review?(vladimir)
Attachment #370618 - Attachment is patch: true
Attachment #370618 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 370618 [details] [diff] [review]
V1: Cleanup of imgIContainer.idl

Don't forget GetAnimationMode()!
Attachment #370618 - Flags: superreview?(vladimir)
Attachment #370618 - Flags: review?(vladimir)
Attachment #370618 - Flags: review+
Attachment #370618 - Flags: superreview?(vladimir) → superreview+
I decided not to do GetAnimationMode, as it comes as SetAnimationMode from the idl attribute 'animationMode'. SetAnimationMode is used in several locations.
So, while we could replace attribute animationMode with an explicit SetAnimationMode, I selected to keep it as an attribute.
http://hg.mozilla.org/mozilla-central/rev/66bc0f3cdb84
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.