Closed
Bug 418896
Opened 14 years ago
Closed 12 years ago
profileserver.py.in shouldn't need to be preprocessed.
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla2.0b11
People
(Reporter: sayrer, Assigned: ewong)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In bug 418772, Ted says > Did your changes remove all of the preprocessor stuff? Could this become a > normal .py file instead of a .py.in now? And it's a good question. Unfortunately, getting relative imports to work with a mix of preprocessed and unpreprocessed files is tricky. We'll need to figure that out, or adjust the module search path somehow.
Comment 1•14 years ago
|
||
Moving a bunch of Core :: Testing bugs to Testing :: Mochitest to clear out the former, which is obsolete now that we have more specialized categories for such bugs; filter on the string "MochitestMmMm" to delete all these notifications.
Component: Testing → Mochitest
Product: Core → Testing
QA Contact: testing → mochitest
Comment 2•13 years ago
|
||
Note that I worked around this with runreftest.py by just $(INSTALL)ing the script to _tests/reftest in the objdir, alongside automation.py. runreftest.py is not preprocessed, as it relies on automation.py for all that dirty work.
Comment 3•12 years ago
|
||
bug 576026 fixed runtests.py.
Summary: runtests.py.in and profileserver.py.in shouldn't need to be preprocessed. → profileserver.py.in shouldn't need to be preprocessed.
Updated•12 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
![]() |
Assignee | |
Updated•12 years ago
|
Assignee: nobody → ewong
![]() |
Assignee | |
Updated•12 years ago
|
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 4•12 years ago
|
||
Attachment #492635 -
Flags: review?(ted.mielczarek)
Comment 5•12 years ago
|
||
Comment on attachment 492635 [details] [diff] [review] Removed profileserver.py from being preprocessed. r=me, but we should probably fix this the same way as bug 614863 gets fixed to avoid problems.
Attachment #492635 -
Flags: review?(ted.mielczarek) → review+
Comment 6•12 years ago
|
||
(In reply to comment #5) > Comment on attachment 492635 [details] [diff] [review] > Removed profileserver.py from being preprocessed. > > r=me, but we should probably fix this the same way as bug 614863 gets fixed to > avoid problems. I just advocated for 614863 to be wontfix. do you have any suggestions/ideas on how to fix that issue easily?
![]() |
||
Updated•12 years ago
|
Keywords: checkin-needed
Comment 7•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ae5dcbff45df
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
You need to log in
before you can comment on or make changes to this bug.
Description
•