profileserver.py.in shouldn't need to be preprocessed.

RESOLVED FIXED in mozilla2.0b11

Status

Testing
Mochitest
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Robert Sayre, Assigned: ewong)

Tracking

unspecified
mozilla2.0b11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
In bug 418772, Ted says
> Did your changes remove all of the preprocessor stuff?  Could this become a
> normal .py file instead of a .py.in now? 

And it's a good question. Unfortunately, getting relative imports to work with a mix of preprocessed and unpreprocessed files is tricky. We'll need to figure that out, or adjust the module search path somehow.

Comment 1

10 years ago
Moving a bunch of Core :: Testing bugs to Testing :: Mochitest to clear out the former, which is obsolete now that we have more specialized categories for such bugs; filter on the string "MochitestMmMm" to delete all these notifications.
Component: Testing → Mochitest
Product: Core → Testing
QA Contact: testing → mochitest
Note that I worked around this with runreftest.py by just $(INSTALL)ing the script to _tests/reftest in the objdir, alongside automation.py. runreftest.py is not preprocessed, as it relies on automation.py for all that dirty work.
bug 576026 fixed runtests.py.
Summary: runtests.py.in and profileserver.py.in shouldn't need to be preprocessed. → profileserver.py.in shouldn't need to be preprocessed.
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Updated

8 years ago
Assignee: nobody → ewong
(Assignee)

Updated

8 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

8 years ago
Created attachment 492635 [details] [diff] [review]
Removed profileserver.py from being preprocessed.
Attachment #492635 - Flags: review?(ted.mielczarek)
Comment on attachment 492635 [details] [diff] [review]
Removed profileserver.py from being preprocessed.

r=me, but we should probably fix this the same way as bug 614863 gets fixed to avoid problems.
Attachment #492635 - Flags: review?(ted.mielczarek) → review+
(In reply to comment #5)
> Comment on attachment 492635 [details] [diff] [review]
> Removed profileserver.py from being preprocessed.
> 
> r=me, but we should probably fix this the same way as bug 614863 gets fixed to
> avoid problems.

I just advocated for 614863 to be wontfix. do you have any suggestions/ideas on how to fix that issue easily?

Updated

8 years ago
Keywords: checkin-needed

Comment 7

8 years ago
http://hg.mozilla.org/mozilla-central/rev/ae5dcbff45df
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b11
Depends on: 629202
You need to log in before you can comment on or make changes to this bug.