418920 - Allow multiple word search with tags in addition to title and url

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

Currently tag searches are special searches that only try matching tags.. We can make things more consistent by doing multiple word searches against the tags and title and url.

This lets the user search for a tag and filter results by typing words from the title, etc.

Comment 1

[Ed Lee :Mardak]

Attachment: testcase v1

Comment 2

[Ed Lee :Mardak]

Do we want this? Bug 401869 which added multi-word searching for title/url was blocking+.

Bug 401660 will fix this.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

So this doesn't *block*, IMO, and we should consider the effect on people's searching habits. I think it's wanted, but I want to make sure that the massive elevation that we give tagged entries doesn't make this annoying in cases where tags and titles collide.

Comment 4

[Ed Lee :Mardak]

Checking in toolkit/components/places/tests/unit/test_history_autocomplete_tags.js;
/cvsroot/mozilla/toolkit/components/places/tests/unit/test_history_autocomplete_tags.js,v  <--  test_history_autocomplete_tags.js
new revision: 1.5; previous revision: 1.4
done

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008042705 Minefield/3.0pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008042704 Minefield/3.0pre