Last Comment Bug 419072 - incorrect hypothetical box right with asymmetric containing block border
: incorrect hypothetical box right with asymmetric containing block border
Status: RESOLVED FIXED
: regression
Product: Core
Classification: Components
Component: Layout: R & A Pos (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla1.9beta4
Assigned To: David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
:
Mentors:
Depends on:
Blocks: 135082 403328
  Show dependency treegraph
 
Reported: 2008-02-22 11:46 PST by David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
Modified: 2008-02-25 13:17 PST (History)
3 users (show)
dbaron: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.49 KB, patch)
2008-02-22 11:46 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
no flags Details | Diff | Splinter Review
patch (2.25 KB, patch)
2008-02-24 10:53 PST, David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch)
roc: review+
roc: superreview+
dsicore: approval1.9+
Details | Diff | Splinter Review

Description David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-22 11:46:10 PST
Created attachment 305051 [details] [diff] [review]
patch

I caught this while writing a reftest for bug 403328.  That bug actually regresses some cases due to this bug because it switches when we use mLeft vs mRight, so I want to land this at the same time.

In any case, nsHTMLReflowState::CalculateHypotheticalBox does the wrong thing when adjusting for the border of the absolute positioning containing block.  mRight is relative to the left edge, so it should adjust it by the left border, but instead it adjusts it by the right border.

This will be tested in my reftest for bug 403328.
Comment 1 Uri Bernstein (Google) 2008-02-22 12:07:15 PST
> I caught this while writing a reftest for bug 403328.  That bug actually
> regresses some cases due to this bug because it switches when we use mLeft vs
> mRight, so I want to land this at the same time.

Not sure whether you noticed - I landed 403328 a few hours ago (with a reftest based on my testcase for that bug).
Comment 2 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-22 12:56:21 PST
(I landed the reftests in question as layout/reftests/box-properties/abspos-* .)
Comment 3 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-24 10:53:48 PST
Created attachment 305373 [details] [diff] [review]
patch

Same as previous, plus changes to reftest.list.
Comment 4 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-24 15:28:31 PST
This mistake was introduced in the patch on bug 135082.
Comment 5 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-24 20:31:51 PST
Comment on attachment 305373 [details] [diff] [review]
patch

Low risk change to fix position used for some absolute positioning cases (most common in RTL documents) where the containing block has asymmetric borders.
Comment 6 Damon Sicore (:damons) 2008-02-25 12:39:49 PST
Comment on attachment 305373 [details] [diff] [review]
patch

a1.9+=damons
Comment 7 David Baron :dbaron: ⌚️UTC-7 (review requests must explain patch) 2008-02-25 13:17:08 PST
Checked in to trunk.

Note You need to log in before you can comment on or make changes to this bug.