419072 - incorrect hypothetical box right with asymmetric containing block border

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I caught this while writing a reftest for bug 403328.  That bug actually regresses some cases due to this bug because it switches when we use mLeft vs mRight, so I want to land this at the same time.

In any case, nsHTMLReflowState::CalculateHypotheticalBox does the wrong thing when adjusting for the border of the absolute positioning containing block.  mRight is relative to the left edge, so it should adjust it by the left border, but instead it adjusts it by the right border.

This will be tested in my reftest for bug 403328.

Comment 1

[Uri Bernstein]

> I caught this while writing a reftest for bug 403328.  That bug actually
> regresses some cases due to this bug because it switches when we use mLeft vs
> mRight, so I want to land this at the same time.

Not sure whether you noticed - I landed 403328 a few hours ago (with a reftest based on my testcase for that bug).

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I landed the reftests in question as layout/reftests/box-properties/abspos-* .)

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Same as previous, plus changes to reftest.list.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This mistake was introduced in the patch on bug 135082.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 305373 [details] [diff] [review]
patch

Low risk change to fix position used for some absolute positioning cases (most common in RTL documents) where the containing block has asymmetric borders.

Comment 6

[Damon Sicore (:damons)]

Comment on attachment 305373 [details] [diff] [review]
patch

a1.9+=damons

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.