Last Comment Bug 419242 - 'all' is not the default makefile target in lib/softoken and lib/softoken/legacydb
: 'all' is not the default makefile target in lib/softoken and lib/softoken/leg...
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Build (show other bugs)
: unspecified
: All All
: -- normal (vote)
: 3.12
Assigned To: Wan-Teh Chang
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-23 18:11 PST by Wan-Teh Chang
Modified: 2008-03-09 16:18 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (1.93 KB, patch)
2008-02-23 18:11 PST, Wan-Teh Chang
christophe.ravel.bugs: review+
Details | Diff | Splinter Review
Supplemental patch (975 bytes, patch)
2008-03-03 15:42 PST, Wan-Teh Chang
christophe.ravel.bugs: review+
Details | Diff | Splinter Review

Description Wan-Teh Chang 2008-02-23 18:11:15 PST
Created attachment 305278 [details] [diff] [review]
Proposed patch

The default makefile target should be 'all' (which is
equivalent to 'export libs') so that when we say

  gmake

it will build the 'all' makefile target.  This requires
that 'all' (from coreconf/rules.mk) be the first makefile
target in the makefile.

This is not the case in lib/softoken and lib/softoken/legacydb
because it has a makefile target defined in the local config.mk,
which is included before coreconf/rules.mk.

The attached patch fixes this problem.
Comment 1 Wan-Teh Chang 2008-02-25 10:56:18 PST
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/softoken/Makefile,v  <--  Makefile
new revision: 1.6; previous revision: 1.5
done
Checking in config.mk;
/cvsroot/mozilla/security/nss/lib/softoken/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done
Checking in legacydb/Makefile;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/Makefile,v  <--  Makefile
new revision: 1.3; previous revision: 1.2
done
Checking in legacydb/config.mk;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/config.mk,v  <--  config.mknew revision: 1.6; previous revision: 1.5
done
Comment 2 Wan-Teh Chang 2008-03-03 15:42:34 PST
Created attachment 307117 [details] [diff] [review]
Supplemental patch

lib/ssl needs the same change because the SSL bypass code also
uses freebl.
Comment 3 Wan-Teh Chang 2008-03-09 16:18:18 PDT
Comment on attachment 307117 [details] [diff] [review]
Supplemental patch

I checked in this patch (for lib/ssl) on the NSS trunk for
NSS 3.12.

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/ssl/Makefile,v  <--  Makefile
new revision: 1.7; previous revision: 1.6
done
Checking in config.mk;
/cvsroot/mozilla/security/nss/lib/ssl/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done

Note You need to log in before you can comment on or make changes to this bug.