'all' is not the default makefile target in lib/softoken and lib/softoken/legacydb

RESOLVED FIXED in 3.12

Status

NSS
Build
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

unspecified
3.12

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

9 years ago
Created attachment 305278 [details] [diff] [review]
Proposed patch

The default makefile target should be 'all' (which is
equivalent to 'export libs') so that when we say

  gmake

it will build the 'all' makefile target.  This requires
that 'all' (from coreconf/rules.mk) be the first makefile
target in the makefile.

This is not the case in lib/softoken and lib/softoken/legacydb
because it has a makefile target defined in the local config.mk,
which is included before coreconf/rules.mk.

The attached patch fixes this problem.
Attachment #305278 - Flags: review?(christophe.ravel.bugs)

Updated

9 years ago
Attachment #305278 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 1

9 years ago
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/softoken/Makefile,v  <--  Makefile
new revision: 1.6; previous revision: 1.5
done
Checking in config.mk;
/cvsroot/mozilla/security/nss/lib/softoken/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done
Checking in legacydb/Makefile;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/Makefile,v  <--  Makefile
new revision: 1.3; previous revision: 1.2
done
Checking in legacydb/config.mk;
/cvsroot/mozilla/security/nss/lib/softoken/legacydb/config.mk,v  <--  config.mknew revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.12
(Assignee)

Comment 2

9 years ago
Created attachment 307117 [details] [diff] [review]
Supplemental patch

lib/ssl needs the same change because the SSL bypass code also
uses freebl.
Attachment #307117 - Flags: review?(christophe.ravel.bugs)

Updated

9 years ago
Attachment #307117 - Flags: review?(christophe.ravel.bugs) → review+
(Assignee)

Comment 3

9 years ago
Comment on attachment 307117 [details] [diff] [review]
Supplemental patch

I checked in this patch (for lib/ssl) on the NSS trunk for
NSS 3.12.

Checking in Makefile;
/cvsroot/mozilla/security/nss/lib/ssl/Makefile,v  <--  Makefile
new revision: 1.7; previous revision: 1.6
done
Checking in config.mk;
/cvsroot/mozilla/security/nss/lib/ssl/config.mk,v  <--  config.mk
new revision: 1.24; previous revision: 1.23
done
You need to log in before you can comment on or make changes to this bug.