419243 - get_new_status_and_resolution() no longer exists and bug moving fails

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Guy Pyrzak]

Try to move a bug to another install using the landfill. You will run into this bug.

In process bug, line 438:        my ($status, $resolution) = $bug->get_new_status_and_resolution('move');

Comment 1

[Frédéric Buclin]

Regression due to bug 402791.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Max Kanat-Alexander]

Comment on attachment 305544 [details] [diff] [review]
patch, v1

I'm not totally happy with adding $moving, but I suppose I see why it's there.

Now that we have so many parameters to set_status and set_resolution, they need to be named parameters after the first one. For example, set_status needs to be:

set_status($status, { resolution => $resolution, dupe_of => $dupe_of, moving => 1 });

Comment 4

[Frédéric Buclin]

Attachment: patch, v2

Comment 5

[Max Kanat-Alexander]

Comment on attachment 305619 [details] [diff] [review]
patch, v2

Okay, looks good to me.

Comment 6

[Frédéric Buclin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.407; previous revision: 1.406
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.235; previous revision: 1.234
done