419348 - build config fixes for profile-guided optimization on mac

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Mac needs a few tweaks for PGO.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: fix xpidl [checked in]

xpidl doesn't work at all with PGO enabled, and we don't really want it there anyway, so this uses the new NO_PROFILE_GUIDED_OPTIMIZE make var I added in some other patch.

Comment 2

[(not currently active) Ted Mielczarek]

This doesn't get us all the way there.  My builds with this don't start, so I never get to the second build pass.  Might need to make MOZ_PROFILE_MODULES work with PGO builds so we can restrict the set of modules we enable this on.  sayrer says he was able to build spidermonkey with PGO and it worked.

Comment 3

[Damon Sicore (:damons)]

Comment on attachment 305394 [details] [diff] [review]
fix xpidl [checked in]

a1.9+=damons

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 305394 [details] [diff] [review]
fix xpidl [checked in]

More investigation needed to figure out what modules are breaking us here.  We could either conditionally add makefile variables to disable PGO in certain modules, or hack --enable-profile-modules to allow us to specify a whitelist of modules for PGO.

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: make profiledbuild work for universal builds

This is going to be a prerequisite to using PGO on mac, since we're doing universal builds there. This would also be necessary for doing other multi-pass builds with PGO, like FF-on-XR.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: allow disabling PGO from configure [checked in]

This is also useful, since we can disable PGO on the ppc half of the build (since we won't be running that code in the profiling anyway). This will save us a clobber and rebuild on that half of the build, which is nice.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 307032 [details] [diff] [review]
make profiledbuild work for universal builds

This isn't quite right. I can't use $(OBJDIR) there, since in the MOZ_BUILD_PROJECTS case it's explicitly set to error out. Need a little special casing for this.

Comment 8

[(not currently active) Ted Mielczarek]

Attachment: make profiledbuild work on universal builds [checked in]

Right, this should actually work.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307054 [details] [diff] [review]
allow disabling PGO from configure [checked in]

a1.9=beltzner

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 307056 [details] [diff] [review]
make profiledbuild work on universal builds [checked in]

a1.9=beltzner

Comment 11

[(not currently active) Ted Mielczarek]

Closing this out to get it off the radar, we'll look at additional fixes in other bugs.