419359 - Compile warning about NS_TargetUnfocusedEventToLastFocusedContent

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Peter Weilbacher]

Since a few days I get warnings like

../../dist/include/widget/nsGUIEvent.h:1251: warning: `PRBool NS_TargetUnfocused
EventToLastFocusedContent(nsEvent*)' defined but not used

when compiling stuff in widget and elsewhere. That is especially irritating as widget/src/os2 (which I recompile often) compiled almost warning free until now.

masayuki, http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/widget/public/nsGUIEvent.h&rev=3.157#1251 tells me that this was added by you in bug 417315. Can you give me a hint if/what we have to implement on OS/2? Is this by any chance related to bug 416670?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Don't mind this warning on OS/2. This is my simple mistake, not an actual bug. And this function is used only on nsPresShell. If software keyboards are not working fine on OS/2, you might need to change the function.

Note that I'm busy for some risky bugs until b4 release, sorry.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 306078 [details] [diff] [review]
Patch v1.0

It's not needed for 1.9b4.

The risk is too low. Only changing |static| to |inline|.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306078 [details] [diff] [review]
Patch v1.0

a1.9=beltzner

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.