Closed Bug 419370 Opened 14 years ago Closed 14 years ago

allow single face font families via pref

Categories

(Core :: Graphics, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jtd, Assigned: jtd)

References

Details

Attachments

(2 files, 2 obsolete files)

On the mac, the monospace font has been typically defined to be Osaka-Mono.  Unfortunately, its family name is Osaka so there's no way to specify this specific face, only its family Osaka.  The solution for this is to allow a pref setting to specify a list of font faces that should be treated as separate families.  This allows Osaka-Mono to exist as a separate font family from Osaka.  This isn't something we want to encourage generally, but it's a simple workaround for dealing with this situation.

Also, move the list of font families whose name table is read in at startup out to a pref.

I've already worked on a patch for this for bug 390901 but that involves more interface work, this just separates out some of the back end work on the mac that needs to get done.
Priority: -- → P3
Requesting blocking since this work is needed to fix bug 390901, a 1.9 blocker.
Status: NEW → ASSIGNED
Flags: blocking1.9?
This patch sets up code that looks for a pref setting 'font.preload-names-list' that lists individual fonts that should be treated as separate families.  This allows for backward-compatible support for Osaka-Mono.

Note: patch also includes cleanup code to move preloading of name tables into a pref setting and the trimming out of bogus italic faces for Helvetica, Courier.
Attachment #305436 - Flags: superreview?(pavlov)
Attachment #305436 - Flags: review?(pavlov)
This shows a comparison of the current trunk to a build with the patch.  With the patch ja locale users see (1) localized font family names and (2) Osaka Mono can be used for the monospace font.
One more note: with the patch there is still the problem of fonts with localized family names not displaying correctly for English locale users.  This is what will be fixed by the rest of 390901.
Moved the code for reading in a font list from a pref into a separate utility routine in gfxFontUtils.[h|cpp]
Attachment #305436 - Attachment is obsolete: true
Attachment #305676 - Flags: superreview?(pavlov)
Attachment #305676 - Flags: review?(pavlov)
Attachment #305436 - Flags: superreview?(pavlov)
Attachment #305436 - Flags: review?(pavlov)
minor cleanups
Attachment #305676 - Attachment is obsolete: true
Attachment #305689 - Flags: superreview?(pavlov)
Attachment #305689 - Flags: review?(pavlov)
Attachment #305676 - Flags: superreview?(pavlov)
Attachment #305676 - Flags: review?(pavlov)
Attachment #305689 - Flags: superreview?(pavlov)
Attachment #305689 - Flags: superreview+
Attachment #305689 - Flags: review?(pavlov)
Attachment #305689 - Flags: review+
Flags: blocking1.9? → blocking1.9+
checked in
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Depends on: 428447
You need to log in before you can comment on or make changes to this bug.