Closed Bug 419392 Opened 12 years ago Closed 12 years ago

Need to catch Cocoa exceptions in Mac file I/O

Categories

(Core :: XPCOM, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: stanshebs, Assigned: jaas)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

The file xpcom/io/nsLocalFileOSX.cpp makes a number of Mac framework calls, in particular manipulations of CFStrings, that can potentially throw Cocoa exceptions that need to be caught by us, and so those calls need to be wrapped in @try-blocks.
There are CFString usages in xpcom/obsolete/nsFileSpecUnix.cpp , not clear to me if that code is actually being used or not.

I'll have IT do a real cvs move for the move here. I want to keep the cvs history.
Assignee: nobody → joshmoz
Status: NEW → ASSIGNED
Attachment #305665 - Flags: superreview?(roc)
xpcom/obsolete isn't built in Firefox, afaik, might be for mailnews but I wouldn't expend any effort there.
Attachment #305665 - Flags: superreview?(roc) → superreview+
landed "cleanup/rename v1.0"
Attached patch fix v1.0 (obsolete) — Splinter Review
Attachment #306536 - Flags: review?(stanshebs)
Attachment #306536 - Flags: review?(stanshebs) → review?(bent.mozilla)
Comment on attachment 306536 [details] [diff] [review]
fix v1.0

r=me if you also remove '-framework Cocoa' in all the makefiles that previously used it now that those lines will be redundant.
Attachment #306536 - Flags: review?(bent.mozilla) → review+
Attached patch fix v1.1Splinter Review
removes redundant flag from other places
Attachment #306536 - Attachment is obsolete: true
Attachment #306563 - Flags: superreview?(roc)
Attachment #306563 - Flags: superreview?(roc) → superreview+
landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Attachment #306563 - Flags: approval1.9b4?
Comment on attachment 306563 [details] [diff] [review]
fix v1.1

a1.9b4=beltzner
Attachment #306563 - Flags: approval1.9b4? → approval1.9b4+
You need to log in before you can comment on or make changes to this bug.