419470 - Figure out why building jemalloc breaks with PGO enabled

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

See bug 418866 comment 6 for error details.  We're just going to disable this for the time being, but we should figure out why it breaks.

Comment 1

[Jason Evans]

My first guess is that profile-guided optimization (PGO) is being tripped up by the use of thread-local storage (TLS).  If so, this is a compiler bug.

Comment 2

[(not currently active) Ted Mielczarek]

Jason: If you'd like to test this yourself, you can add this line to your mozconfig:
mk_add_options PROFILE_GEN_SCRIPT='$(PYTHON) $(MOZ_OBJDIR)/_profile/pgo/profileserver.py'

And then build using |make -f client.mk profiledbuild|. We're using GCC 4.1.1 (+ Redhat patches) on trunk:
http://wiki.mozilla.org/ReferencePlatforms/Linux-CentOS-5.0#Make_GCC_4.1_.28redhat_branch.29

Comment 3

[(not currently active) Ted Mielczarek]

Also, for reference, I didn't see this on x86-64 with gcc 4.1.2 (Ubuntu 4.1.2-0ubuntu4)

Comment 4

[(not currently active) Ted Mielczarek]

Taras, we currently have PGO disabled for jemalloc. Can you see if this is still a problem with a modern GCC? It's just a matter of removing the NO_PROFILE_GUIDED_OPTIMIZE here:
http://mxr.mozilla.org/mozilla-central/source/memory/jemalloc/Makefile.in#135

Comment 5

[(dormant account)]

This is still busted in 4.5. Haven't had a chance to check why.

Comment 6

[(Away)]

Attachment: re-enable

Looks fine now: https://treeherder.mozilla.org/#/jobs?repo=try&revision=36ee285db1171d5aa813f29a28154ec20cea546c

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/972714aa03b2
Re-enable PGO for Linux mozjemalloc. r=glandium

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/972714aa03b2