419496 - Cannot easily share saved searches

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement, P2)

Description

[Frédéric Buclin]

When you share one of your saved search, you have no idea what the URL is for other users, and so you cannot simply paste it on IRC or on your blog. All you can say is "go to your user prefs and select my shared search named foo_bar". It would be easier and more efficient for everybody to have a unique URL which works for everybody.

Of course, other users still need to be in the group you share your search with.

Comment 1

[David Lawrence [:dkl]]

Attachment: Patch to create saved search link in userprefs.cgi (v1)

Here is the patch that we use at Red Hat to accomplish this. People can then copy the link and send it to others without having to have the user go to their userprefs.cgi page first.

Dave

Comment 2

[Frédéric Buclin]

Comment on attachment 353061 [details] [diff] [review]
Patch to create saved search link in userprefs.cgi (v1)

>+              (<a href="buglist.cgi?cmdtype=dorem&amp;remaction=run&amp;namedcmd=
>+                        [% q.name FILTER url_quote %]&amp;sharer_id=
>+                        [% user.id FILTER url_quote %]">Link</a>)

Rather than adding another link in the already complex table, we should replace the URL of the existing "Run" link by this one above, and fix buglist.cgi (or Bugzilla::Search::Saved) to accept this URL even if the query is not shared when it detects that sharer_id == Bugzilla->user->id. This way, we don't need two different syntax for the sharer himself and for other users. Of course, we should still support the "old" URL for compatibility.

Comment 3

[David Lawrence [:dkl]]

Attachment: Patch to create saved search link in userprefs.cgi (v2)

Actually no changes to buglist.cgi are necessary. Just need to change the Run link under userprefs.cgi and it should work fine in all cases. Patch attached
for review.

Thanks
Dave

Comment 4

[Frédéric Buclin]

Comment on attachment 353542 [details] [diff] [review]
Patch to create saved search link in userprefs.cgi (v2)

>+          <a href="buglist.cgi?cmdtype=dorem&amp;remaction=run&amp;namedcmd=[% q.name FILTER url_quote %][% IF q.shared_with_group.id %]&amp;sharer_id=[% user.id FILTER url_quote %][% END %]">Run</a>

Wow, nice catch. Simply omitting sharer_id when not sharing the query does indeed work (I checked the source code, and tested your patch). Would be nice if you could break your long line on checkin, maybe something like this:

          <a href="buglist.cgi?cmdtype=dorem&amp;remaction=run&amp;namedcmd=[% q.name FILTER url_quote %][%
              IF q.shared_with_group.id %]&amp;sharer_id=[% user.id FILTER url_quote %][% END %]">Run</a>

r=LpSolit

Comment 5

[David Lawrence [:dkl]]

tip:
Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v  <--  saved-searches.html.tmpl
new revision: 1.19; previous revision: 1.18
done