Closed Bug 419520 Opened 12 years ago Closed 12 years ago

Provide url (or file path) for error messages

Categories

(Core :: DOM: Navigation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

Details

Attachments

(1 file)

Attached patch proposalSplinter Review
an embedder would like to be able to use the url/file path in error messages.

two optional items are provided

host:port and url

url is available as the last parameter for all messages
host:port is available as the first parameter for:
NS_ERROR_CONNECTION_REFUSED
NS_ERROR_NET_INTERRUPT
NS_ERROR_PORT_ACCESS_NOT_ALLOWED

Localizations should not be affected by this change as they're merely additional fields that could be used but will not be used today.
Attachment #305580 - Flags: review?(cbiesinger)
Attachment #305580 - Flags: review?(cbiesinger) → review+
Comment on attachment 305580 [details] [diff] [review]
proposal

+                // UnEscapeURIForUI always succeeds 
+                textToSubURI->UnEscapeURIForUI(charset, spec, formatStrs[formatStrCount]);

maybe it would be good not to rely on that, and just assign the return value to rv. the code below will do the right thing.
Attachment #305580 - Flags: approval1.9?
Comment on attachment 305580 [details] [diff] [review]
proposal

a1.9+=damons
Attachment #305580 - Flags: approval1.9? → approval1.9+
Comment on attachment 305580 [details] [diff] [review]
proposal

mozilla/docshell/base/nsDocShell.cpp 	1.889
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.