419520 - Provide url (or file path) for error messages

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[timeless]

Attachment: proposal

an embedder would like to be able to use the url/file path in error messages.

two optional items are provided

host:port and url

url is available as the last parameter for all messages
host:port is available as the first parameter for:
NS_ERROR_CONNECTION_REFUSED
NS_ERROR_NET_INTERRUPT
NS_ERROR_PORT_ACCESS_NOT_ALLOWED

Localizations should not be affected by this change as they're merely additional fields that could be used but will not be used today.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 305580 [details] [diff] [review]
proposal

+                // UnEscapeURIForUI always succeeds 
+                textToSubURI->UnEscapeURIForUI(charset, spec, formatStrs[formatStrCount]);

maybe it would be good not to rely on that, and just assign the return value to rv. the code below will do the right thing.

Comment 2

[Damon Sicore (:damons)]

Comment on attachment 305580 [details] [diff] [review]
proposal

a1.9+=damons

Comment 3

[timeless]

Comment on attachment 305580 [details] [diff] [review]
proposal

mozilla/docshell/base/nsDocShell.cpp 	1.889