419545 - Hang on print preview with overflow: scroll, float, frameset and xul box

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase which hangs on print preview with current trunk build.
It doesn't hang with a 2008-02-13 build, but does hang with a 2008-02-15 build:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-13+04&maxdate=2008-02-15+09&cvsroot=%2Fcvsroot
My guess is a regression from bug 399676 somehow.

Comment 1

[Boris Zbarsky [:bzbarsky]]

> My guess is a regression from bug 399676 somehow.

Except there's no <mtd> involved...

Comment 2

[Boris Zbarsky [:bzbarsky]]

0xb4d8f5cd in nsLeafFrame::GetIntrinsicHeight (this=0x8847788)
    at ../../../mozilla/layout/generic/nsLeafFrame.cpp:131
131       NS_NOTREACHED("Someone didn't override Reflow or ComputeAutoSize");
(gdb) p this
$1 = (nsHTMLFramesetBlankFrame *) 0x8847788

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sadly, fixing that (which is pretty easy) doesn't fix this bug.  I get:

nsBlockReflowContext: Frameset(frameset)(1)@0x89ca0e8 metrics=0,1073741824!
nsBlockReflowContext: HTMLScroll(div)(1)@0x89c9d94 metrics=0,1073743264!

and then loop for a very long time in nsLineLayout::AddFloat stuff.  

Perhaps having mMaximalLeftYMost = -1073741824, mMaximalRightYMost = -1073741824 in the space manager is affecting things?

Comment 4

[Martijn Wargers (dead)]

(In reply to comment #1)
> > My guess is a regression from bug 399676 somehow.
> 
> Except there's no <mtd> involved...

Argh, sorry, stupid guess.
This is a more precise regression range (using hourly builds):
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-14+00&maxdate=2008-02-14+06&cvsroot=%2Fcvsroot

So this has to be a regression from bug 400813, somehow.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Yeah, that I can buy!