Closed
Bug 419739
Opened 17 years ago
Closed 14 years ago
threadsafe nsRandomGenerator
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
VERIFIED
DUPLICATE
of bug 607115
People
(Reporter: dcamp, Assigned: dcamp)
Details
Attachments
(1 file)
|
912 bytes,
patch
|
KaiE
:
review+
sdwilsh
:
review+
|
Details | Diff | Splinter Review |
I'd like to use nsIRandomGenerator from the url-classifier thread.
I believe the underlying implementation is threadsafe, so it should just need threadsafe refcounting.
Attachment #305870 -
Flags: review?(kengert)
|
Assignee | |
Updated•17 years ago
|
Attachment #305870 -
Flags: review?(sdwilsh)
|
||
Updated•17 years ago
|
Assignee: kengert → dcamp
Version: unspecified → Trunk
|
||
Comment 1•17 years ago
|
||
Comment on attachment 305870 [details] [diff] [review]
v1
This change is fine. It seems undefined whether this contract is to be used as a service or as an instance. Both should be fine, because the implementation does not require any state.
I guess you wouldn't need this change if you used GetInstance, but I agree we should support GetService.
r=kengert
Attachment #305870 -
Flags: review?(kengert) → review+
|
||
Comment 2•17 years ago
|
||
Comment on attachment 305870 [details] [diff] [review]
v1
presently it doesn't matter if it is used as a service or as an independent instance.
r=sdwilsh
Attachment #305870 -
Flags: review?(sdwilsh) → review+
|
||
Comment 3•14 years ago
|
||
This change was implemented in bug 607115, part 1.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 4•14 years ago
|
||
Wow. I can't believe that I actually reviewed a change that didn't land that I ended up implementing three years later...
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•