Closed Bug 419739 Opened 12 years ago Closed 9 years ago

threadsafe nsRandomGenerator

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

VERIFIED DUPLICATE of bug 607115

People

(Reporter: dcamp, Assigned: dcamp)

Details

Attachments

(1 file)

Attached patch v1Splinter Review
I'd like to use nsIRandomGenerator from the url-classifier thread.

I believe the underlying implementation is threadsafe, so it should just need threadsafe refcounting.
Attachment #305870 - Flags: review?(kengert)
Attachment #305870 - Flags: review?(sdwilsh)
Assignee: kengert → dcamp
Version: unspecified → Trunk
Comment on attachment 305870 [details] [diff] [review]
v1

This change is fine. It seems undefined whether this contract is to be used as a service or as an instance. Both should be fine, because the implementation does not require any state.

I guess you wouldn't need this change if you used GetInstance, but I agree we should support GetService.

r=kengert
Attachment #305870 - Flags: review?(kengert) → review+
Comment on attachment 305870 [details] [diff] [review]
v1

presently it doesn't matter if it is used as a service or as an independent instance.

r=sdwilsh
Attachment #305870 - Flags: review?(sdwilsh) → review+
This change was implemented in bug 607115, part 1.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 607115
Wow.  I can't believe that I actually reviewed a change that didn't land that I ended up implementing three years later...
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.