Closed
Bug 419757
Opened 17 years ago
Closed 17 years ago
cache codepoints for which no font matches on windows
Categories
(Core :: Graphics, defect, P3)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jtd, Assigned: jtd)
Details
Attachments
(1 file)
9.32 KB,
patch
|
pavlov
:
review+
pavlov
:
superreview+
pavlov
:
approval1.9+
|
Details | Diff | Splinter Review |
Flags: blocking1.9?
Assignee | ||
Comment 1•17 years ago
|
||
The mac font matching code caches codepoints for which no font was found:
http://mxr.mozilla.org/mozilla/source/gfx/thebes/src/gfxQuartzFontCache.mm#1026
This helps a lot when rendering pages that contain lots of missing characters, something that often occurs when pages are encoded incorrectly or lack a charset meta tag.
This is a fairly small, well-contained change.
Priority: -- → P3
Assignee | ||
Comment 2•17 years ago
|
||
Port over the same code from Mac. Also switch FindFontForString to FindFontForChar, since this function was only called for single codepoints. This avoid swizzling back and forth between UTF16 and UCS4.
Updated•17 years ago
|
Flags: tracking1.9? → blocking1.9?
Comment 3•17 years ago
|
||
Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches
+ mCodepointsWithNoFonts.reset ();
get rid of the space between reset and ()
Attachment #305960 -
Flags: superreview+
Attachment #305960 -
Flags: review+
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9-
Comment 4•17 years ago
|
||
Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches
this should land for 1.9 after b4
Attachment #305960 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #305960 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 5•17 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•