Closed Bug 419757 Opened 13 years ago Closed 13 years ago

cache codepoints for which no font matches on windows

Categories

(Core :: Graphics, defect, P3)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: jtd, Assigned: jtd)

Details

Attachments

(1 file)

 
Flags: blocking1.9?
The mac font matching code caches codepoints for which no font was found:

http://mxr.mozilla.org/mozilla/source/gfx/thebes/src/gfxQuartzFontCache.mm#1026

This helps a lot when rendering pages that contain lots of missing characters, something that often occurs when pages are encoded incorrectly or lack a charset meta tag.

This is a fairly small, well-contained change.
Priority: -- → P3
Port over the same code from Mac.  Also switch FindFontForString to FindFontForChar, since this function was only called for single codepoints.  This avoid swizzling back and forth between UTF16 and UCS4.
Flags: tracking1.9? → blocking1.9?
Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches

+    mCodepointsWithNoFonts.reset ();

get rid of the space between reset and ()
Attachment #305960 - Flags: superreview+
Attachment #305960 - Flags: review+
Flags: blocking1.9? → blocking1.9-
Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches

this should land for 1.9 after b4
Attachment #305960 - Flags: approval1.9?
Attachment #305960 - Flags: approval1.9? → approval1.9+
checked in
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.