419757 - cache codepoints for which no font matches on windows

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[John Daggett (:jtd)]

Comment 1

[John Daggett (:jtd)]

The mac font matching code caches codepoints for which no font was found:

http://mxr.mozilla.org/mozilla/source/gfx/thebes/src/gfxQuartzFontCache.mm#1026

This helps a lot when rendering pages that contain lots of missing characters, something that often occurs when pages are encoded incorrectly or lack a charset meta tag.

This is a fairly small, well-contained change.

Comment 2

[John Daggett (:jtd)]

Attachment: patch, v.0.1, cache codepoints for which no font matches

Port over the same code from Mac.  Also switch FindFontForString to FindFontForChar, since this function was only called for single codepoints.  This avoid swizzling back and forth between UTF16 and UCS4.

Comment 3

[Stuart Parmenter]

Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches

+    mCodepointsWithNoFonts.reset ();

get rid of the space between reset and ()

Comment 4

[Stuart Parmenter]

Comment on attachment 305960 [details] [diff] [review]
patch, v.0.1, cache codepoints for which no font matches

this should land for 1.9 after b4

Comment 5

[John Daggett (:jtd)]

checked in