419826 - Make browser mochitests run on SeaMonkey

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Robert Kaiser]

I'm adding browser mochitests for suite/ code in bug 416233 - it would be nice to make the framework for those be able to run out of the box.

For locally running the tests, I only needed two small changes, which was 1) using the different chrome URL for SeaMonkey (we'll need to do some detection there) and 2) moving some Cc/Ci vars to a more global scope in the same file (as those aren't defined by default in SeaMonkey.

With those small changes, we should be able to get the framework to run on one more application! :)

Comment 1

[Robert Kaiser]

Attachment: patch: change browser mochtiest framework to run on the suite

This small patch makes the browser mochitests run on both Firefox and SeaMonkey trunk (tested with both on Linux).
Firefox still runs with no failures, SeaMonkey fails tests that need FUEL or the toolkit download manager, but succeeds on the others.

Comment 2

[Robert Kaiser]

Comment on attachment 306316 [details] [diff] [review]
patch: change browser mochtiest framework to run on the suite

>+if (Cc == undefined) {

Actually, === might be even better here - changed locally thanks to ajschult pointing this out.

Comment 3

[Robert Kaiser]

Attachment: patch v2: also make runtests.pl work

gavin pointed me to the .pl version still being run by the buildbot machines, so if we get bug 416469 resolved, we need that ifdefed as well, carrying forward review per his IRC comment saying I don't need re-review.

Does this need approval?

Comment 4

[Jeff Walden [:Waldo]]

I believe because it's a test-only change it doesn't.

Can I nitpick and ask that the chrome URL for the overlay be moved into a ALL_CAPS_CONSTANT at the top of the files with the other such constants?  :-)

Comment 5

[Robert Kaiser]

OK, added the constant named BROWSER_CHROME_URL (as it's the same as the browser.chromeURL pref) and checked in.