419940 - Incorrect JavaAdapter generation for base class that overrides an abstract method

Status: RESOLVED FIXED

(Rhino Graveyard :: Compiler, defect)

Description

[Norris Boyd]

If you define a class as so:
public abstract class BaseFoo {
  public abstract String doSomething();
}
public class Foo extends BaseFoo {
  public String doSomething() {
     return "hello world";
  }
}

and you do in Rhino:
var aFoo = new JavaAdapter(Packages.com.google.Foo, {});

what is the return of:
aFoo.doSomething()

The answer is... the string 'undefined'!

Should be "hello world".

Comment 1

[Norris Boyd]

Attachment: 419940.patch

Proposed patch

Comment 2

[Norris Boyd]

Attachment: testsrc\org\mozilla\javascript\tests\Bug419940Test.java

Comment 3

[Norris Boyd]

Fixed:

Checking in testsrc/org/mozilla/javascript/tests/Bug419940Test.java;
/cvsroot/mozilla/js/rhino/testsrc/org/mozilla/javascript/tests/Bug419940Test.jav
a,v  <--  Bug419940Test.java
initial revision: 1.1
done
Checking in src/org/mozilla/javascript/JavaAdapter.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/JavaAdapter.java,v  <--  Ja
vaAdapter.java
new revision: 1.112; previous revision: 1.111
done