419967 - Cannot search in application/javascript page

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect, P2)

Description

[Dave Townsend [:mossop]]

When viewing a plain text document the find bar will not open. The menu options in edit are greyed out, access keys just beep at me leaving me sad and frustrated.

Comment 1

[Steven Michaud [:smichaud] (Retired)]

Is this Mac-specific?

In any case I can't reproduce it.

I used TextWrangler to create a text document with a couple of
paragraphs of "This is some text.", repeated multiple times.  Then I
saved it using the Mac OS Roman character set and Unix line breaks.
Then I opened it in todays Minefield OS X nightly (File : Open), and
had no trouble searching in it.

Right-slash ('/') and command-f both opened the Find bar, which worked
perfectly.  Edit : Find also worked.

Comment 2

[Steven Michaud [:smichaud] (Retired)]

I should mention that I saved my file as a *.txt file.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

WFM on Vista

Comment 4

[Steven Michaud [:smichaud] (Retired)]

Dtownsend, please tell me more about how to reproduce this problem.
Otherwise I'll have to resolve it WFM or INCOMPLETE.

Comment 5

[Dave Townsend [:mossop]]

Go to this url:

http://www.oxymoronical.com/experiments/tindermerge/tindermerge.js

Try to search using '/', command-f or the find menu item. Fail.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #3)
> WFM on Vista

Err, no it doesn't.

Comment 7

[Steven Michaud [:smichaud] (Retired)]

(In reply to comment #5)

Bingo!  Thanks.

This also happens in Windows (as beltzner has noted).

It's an odd problem, though.  If I copy tindermerge.js to my own
Apache server and access it there, I don't see this problem.  Possibly
there's something wrong with the way it's being served by
oxymoronical.

However that may be, though, this is still a bug in Firefox.

Comment 8

[Steven Michaud [:smichaud] (Retired)]

Silly bugzilla.

Comment 9

[Dave Townsend [:mossop]]

The server it is on is a standard dreamhost account so I'm not sure there is anything fancy going on with it. Headers are:

Date: Mon, 03 Mar 2008 17:10:25 GMT
Server: Apache/2.0.61 (Unix) PHP/4.4.7 mod_ssl/2.0.61 OpenSSL/0.9.7e mod_fastcgi/2.4.2 DAV/2 SVN/1.4.2
Last-Modified: Tue, 19 Feb 2008 23:52:10 GMT
Etag: "31dd492-1e02-8f92be80"
Accept-Ranges: bytes
Content-Length: 7682
Keep-Alive: timeout=2, max=100
Connection: Keep-Alive
Content-Type: application/javascript

Comment 10

[Steven Michaud [:smichaud] (Retired)]

My Apache server sends it as type application/x-javascript.

Could that make the difference?

Comment 11

[Steven Michaud [:smichaud] (Retired)]

> Could that make the difference?

It does.

Comment 12

[Mike Connor [:mconnor]]

fail.

http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#3359

Comment 13

[Mike Connor [:mconnor]]

Attachment: fix slightly naive isImage check

Probably should look at this a little harder at some point, but good enough for now.  Stupidly obvious...

Comment 14

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 307777 [details] [diff] [review]
fix slightly naive isImage check

Add this to the one in findbar.xml, too?

Comment 15

[:Gavin Sharp [email: [e-mail]]]

SeaMonkey will probably want to fix theirs as well.

Comment 16

[Mike Connor [:mconnor]]

Attachment: fix it in both places (for checkin)

also added a comment to check the other method to both places.  Really wish this was factored better, but not the time to do code cleanup.

Comment 17

[Mike Connor [:mconnor]]

Checked in.

Comment 18

[Bruno 'Aqualon' Escherl]

(In reply to comment #15)
> SeaMonkey will probably want to fix theirs as well.
Filed bug 421365 for it.

Comment 19

[Marcia Knous [:marcia]]

Verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030704 Minefield/3.0b5pre and the Win XP nightly. Verified using the site referenced in Comment 5.