420198 - Missing PR_TRUE assignment results in performance loss

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Scott Turner]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_2; en-us) AppleWebKit/525.9 (KHTML, like Gecko) Version/3.1 Safari/525.9
Build Identifier: HEAD

In widget/src/windows/nsWindow.cpp there is a missing PR_TRUE assignment to didCheck in method GetWindowsVersion...

 PRInt32 GetWindowsVersion()
{
  static PRInt32 version = 0;
  static PRBool didCheck = PR_FALSE;

  if (!didCheck)
  {
    OSVERSIONINFOEX osInfo;
    osInfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX);
    // This cast is safe and supposed to be here, don't worry
    ::GetVersionEx((OSVERSIONINFO*)&osInfo);
    version = (osInfo.dwMajorVersion & 0xff) << 8 | (osInfo.dwMinorVersion & 0xf
f);
  }
  return version;
}

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Great catch!

Comment 2

[Reed Loden [:reed]]

Comment on attachment 306397 [details] [diff] [review]
patch - v1

caching ftw!

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306397 [details] [diff] [review]
patch - v1

a1.9b4=beltzner

Comment 4

[Reed Loden [:reed]]

Bug 355789 caused this regression.

Comment 5

[Reed Loden [:reed]]

Checking in widget/src/windows/nsWindow.cpp;
/cvsroot/mozilla/widget/src/windows/nsWindow.cpp,v  <--  nsWindow.cpp
new revision: 3.728; previous revision: 3.727
done