420252 - Duplicated code in browser.css

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Alfred Kayser]

The following code is duplicated:

294 toolbar[mode="icons"] #back-button .toolbarbutton-text-box,
295 toolbar[mode="icons"] #forward-button .toolbarbutton-text-box,
296 #back-button .toolbarbutton-menubutton-dropmarker,
297 #forward-button .toolbarbutton-menubutton-dropmarker {
298   display: none;
299 }
300 
301 toolbar[mode="icons"] #back-button .toolbarbutton-text-box,
302 toolbar[mode="icons"] #forward-button .toolbarbutton-text-box,
303 #back-button .toolbarbutton-menubutton-dropmarker,
304 #forward-button .toolbarbutton-menubutton-dropmarker {
305   display: none;
306 }
307 

I found this while researching why the Mac version of Firefox still has dropdownbuttons in the back and forward buttons in the unified toolbar button construct.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Good catch!

Comment 2

[Asaf Romano (gone)]

Comment on attachment 306467 [details] [diff] [review]
patch - v1

r=mano

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306467 [details] [diff] [review]
patch - v1

after b4, I'm sure reed will make sure we don't lose track

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306467 [details] [diff] [review]
patch - v1

a1.9=beltzner

Comment 5

[Reed Loden [:reed]]

Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.132; previous revision: 1.131
done

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030804 Minefield/3.0b5pre ID:2008030804