Closed Bug 420252 Opened 16 years ago Closed 16 years ago

Duplicated code in browser.css

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 3 beta5

People

(Reporter: alfredkayser, Assigned: reed)

References

Details

Attachments

(1 file)

patch - v1
1.12 KB, patch
asaf
: review+
beltzner
: approval1.9b4-
beltzner
: approval1.9+
Details | Diff | Splinter Review 
The following code is duplicated:

294 toolbar[mode="icons"] #back-button .toolbarbutton-text-box,
295 toolbar[mode="icons"] #forward-button .toolbarbutton-text-box,
296 #back-button .toolbarbutton-menubutton-dropmarker,
297 #forward-button .toolbarbutton-menubutton-dropmarker {
298   display: none;
299 }
300 
301 toolbar[mode="icons"] #back-button .toolbarbutton-text-box,
302 toolbar[mode="icons"] #forward-button .toolbarbutton-text-box,
303 #back-button .toolbarbutton-menubutton-dropmarker,
304 #forward-button .toolbarbutton-menubutton-dropmarker {
305   display: none;
306 }
307 

I found this while researching why the Mac version of Firefox still has dropdownbuttons in the back and forward buttons in the unified toolbar button construct.
Attached patch patch - v1 — — Splinter Review 
Good catch!
Assignee: nobody → reed
Status: NEW → ASSIGNED
Attachment #306467 - Flags: review?(mano)
Version: unspecified → Trunk
Comment on attachment 306467 [details] [diff] [review]
patch - v1

r=mano
Attachment #306467 - Flags: review?(mano) → review+
Attachment #306467 - Flags: approval1.9b4?
Attachment #306467 - Flags: approval1.9?
Comment on attachment 306467 [details] [diff] [review]
patch - v1

after b4, I'm sure reed will make sure we don't lose track
Attachment #306467 - Flags: approval1.9b4? → approval1.9b4-
Comment on attachment 306467 [details] [diff] [review]
patch - v1

a1.9=beltzner
Attachment #306467 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in browser/themes/pinstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/browser.css,v  <--  browser.css
new revision: 1.132; previous revision: 1.131
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008030804 Minefield/3.0b5pre ID:2008030804
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.