420351 - List item marker takes up room now with list-style-type: none in strict mode

Status: RESOLVED FIXED

(Core :: Layout, defect, P1)

Description

[Martijn Wargers (dead)]

Attachment: testcase (strict mode)

Maybe this is intentional, but this is a change in rendering, causing a small layout problem at the mentioned site.
The problem doesn't show in quirks mode.

This regressed between 2008-02-13 and 2008-02-14:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-13+04&maxdate=2008-02-14+09&cvsroot=%2Fcvsroot
I guess a regression from bug 400813.

Here is the relevant spec text, afaict:
http://www.w3.org/TR/CSS21/generate.html#propdef-list-style-type
http://www.w3.org/TR/css3-lists/#list-content

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase (quirks mode)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is probably a real layout regression we should fix for 1.9. Probably just need to check for empty bullets in nsLineLayout::ReflowFrame's test for empty content.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Simple enough. I got tired of hasNoncollapsedContent and changed it to isEmpty (reversing the sense). I also took out the default assignment so compiler warnings are more useful.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 308359 [details] [diff] [review]
fix

r+sr=dbaron

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Backed out because of Linux reftest failures

REFTEST UNEXPECTED FAIL: file:///builds/slave/trunk_centos5/mozilla/layout/reftests/bugs/347348-1.xhtml
REFTEST UNEXPECTED FAIL: file:///builds/slave/trunk_centos5/mozilla/layout/reftests/bugs/347496-1.xhtml
REFTEST UNEXPECTED FAIL: file:///builds/slave/trunk_centos5/mozilla/layout/reftests/bugs/355548-3.xml

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

These failures were because isEmpty is used uninitialized when frameType is null. That happens for MathML frames. Yay cross-platform testing!

Boo to gcc for not giving uninitialized variable warnings with -O0 :-(

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: additional patch on top of the last patch

Here's the additional fix. I'll reland with this.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Relanded