420438 - Enable better scaling on OS/2

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Peter Weilbacher]

Attachment: [checked in] do it

Windows and Mac now have much nicer image scaling, I want that on OS/2, too. The patch seems to do that.

The testcases from bug 324698 all work for me with this patch. There's still bug 419277 but as that will be fixed in a cross-platform way, so that should be OK.

I don't actually know if we want EXTEND_PAD or if that causes something bad. I don't see any problems with it.

Comment 1

[Walter Meinl]

Peter, you've to r+ it on the page, I'm not allowed.
I tested the patch on firefox and yes it really zooms nicer than before.
Do you keep your eye on https://bugzilla.mozilla.org/attachment.cgi?id=306602 from bug419277? I see down in the attachment as well an #if !defined(XP_MACOSX) && !defined(XP_WIN) so it could be that we want that too.
Another issue I see with zooming that is not related to this bug (also seen in older seamonkeys) is that the scrollbars also get zoomed. I didn't have yet a look on other platforms if its there an issue, too. 

Comment 2

[Peter Weilbacher]

Comment on attachment 306703 [details] [diff] [review]
[checked in] do it

Walter said OK. :-)

Asking for approval for an OS/2 only change in a cross-platform file.

Comment 3

[Peter Weilbacher]

(In reply to comment #1)
> Do you keep your eye on https://bugzilla.mozilla.org/attachment.cgi?id=306602
> from bug419277? I see down in the attachment as well an #if !defined(XP_MACOSX)
> && !defined(XP_WIN) so it could be that we want that too.

I tried the fix and I didn't see the problem any more afterwards, even without any XP_OS2 in ThebesDrawTile(), so I think we are good.

> Another issue I see with zooming that is not related to this bug (also seen in
> older seamonkeys) is that the scrollbars also get zoomed. I didn't have yet a
> look on other platforms if its there an issue, too. 

Yes, that's bug 401213. (I tried to take a look but so far haven't found anything that would really work.)

Comment 4

[Peter Weilbacher]

(In reply to comment #3)
> I tried the fix and I didn't see the problem any more afterwards, even without
> any XP_OS2 in ThebesDrawTile(), so I think we are good.

Urgs, I'm blind... Yes, we should change that to except OS/2, too. (The bug was still fixed but it didn't look as nice...) Will comment in that bug.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 306703 [details] [diff] [review]
[checked in] do it

a1.9b4=beltzner

Comment 6

[Peter Weilbacher]

Comment on attachment 306703 [details] [diff] [review]
[checked in] do it

OK, checked this into trunk.

Comment 7

[Peter Weilbacher]

Perhaps we should leave the bug open until we see bug 419277 fixed.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #7)
> Perhaps we should leave the bug open until we see bug 419277 fixed.

I'm not clear on the "why" - does this bug cause that one? Just want to make sure we don't lose track and have this bug linger for a long time :)

Comment 9

[Peter Weilbacher]

beltzner: sorry for the confusion. There is no causal relation. This morning it somehow made sense, no longer does... I'll close this. :-)