420580 - missing padding for (content) dropdowns on XP

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect, P2)

Description

[Simon Bünzli]

Our dropdowns have always had 1px less padding for XP visual styles. With the changes by bug 418552, that's 1px too few for some of them (on Luna it's just 1px too few to look native, though).

Comment 1

[Simon Bünzli]

Attachment: screenshot comparing dropdowns for Luna and another visual style

IE7 is pretty much native, while Gecko seems to get quite confused by the different visual style (from <http://spaceqcg.deviantart.com/art/VistaCG-27363349>).

Comment 2

[Simon Bünzli]

Attachment: minimal fix

The minimal fix would be to add the padding for all visual styles. Depending on how those dropdowns look on Vista, we might even want to add the padding for chrome widgets as well (or maybe only for !mIsVistaOrLater).

Comment 3

[Simon Bünzli]

Attachment: screenshot of the missing border

Adding to the screenshot from comment #1: When not focused, Gecko content doesn't display anything at all instead of the focus outline for this particular visual style. Not sure how broken dropdowns look in other visual styles...

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 306877 [details] [diff] [review]
minimal fix

Looks Ok but I feel like I should run this past someone else ...

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 306877 [details] [diff] [review]
minimal fix

Hm, so this is due to PaintFocus() drawing a background colored outline.  This is needed for a vista-ish theme in use under XP?  This fix looks fine, though this will change how we render these dropdowns under XP -- though from your screenshot it looks like we do want one more pixel everywhere.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Not going to block beta 4 on this, and sadly it's too late for a patch.

Comment 7

[Reed Loden [:reed]]

Comment on attachment 306877 [details] [diff] [review]
minimal fix

This is a blocker. No approval1.9 needed.

Comment 8

[Reed Loden [:reed]]

Checking in widget/src/windows/nsNativeThemeWin.cpp;
/cvsroot/mozilla/widget/src/windows/nsNativeThemeWin.cpp,v  <--  nsNativeThemeWin.cpp
new revision: 3.106; previous revision: 3.105
done

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

This is not relnote worthy.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008050614 Minefield/3.0pre and Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9pre) Gecko/2008050606 Minefield/3.0pre ID:2008050606