420675 - bolding 500 weight text on Windows

Status: VERIFIED FIXED

(Core :: Graphics, defect, P2)

Description

[John Daggett (:jtd)]

Attachment: screenshot, times roman at different weights, ff2 vs. ff3

Looks like we're bolding text in the situation where a regular weight (400) and bold weight (700) face exist.  By CSS rules, in this situation 500 should map to 400, 600 should map to 700.  FF2, IE, Safari all render this way.

Comment 1

[John Daggett (:jtd)]

Attachment: testcase, various fonts at different weights

First set of text lines render Times Roman at weights 100 - 900.  The plain/bold transition on Windows occurs at weight 500 instead of 600 as expected.

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Over to Stuart, unless this is more up your alley John?

Comment 3

[Stuart Parmenter]

Attachment: fix?

Comment 4

[Stuart Parmenter]

Attachment: fix? with synthetic bold

this one adds support for using the magic synthetic bold that windows provides for font weight of 600.  i'm not sure this is better in all cases, but doesn't seem horrible.

Comment 5

[Stuart Parmenter]

Attachment: alternate fix

this one just special cases 500 and makes it be 400 if it doesn't exist.

Comment 6

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 309273 [details] [diff] [review]
alternate fix

Isn't dc null there?  It seems like the loop sets it up if it needs a dc.

Comment 7

[Stuart Parmenter]

Attachment: fix that checks the dc.

Comment 8

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 309304 [details] [diff] [review]
fix that checks the dc.

looks fine, could also use a goto instead of adding another nested if ()

Comment 10

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031905 Minefield/3.0b5pre. I used the testcase in Comment 1 to verify.