420700 - Calling createContextualFragment affects subsequent setting of innerHTML

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[sevenfurnace]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b4pre) Gecko/2008030303 Minefield/3.0b4pre

When you call range.createContextualFragment, and then set innerHTML on an element, the element contains the contents of DocumentFragment created by createContextualFragment.

Reproducible: Always

Steps to Reproduce:
1.Create DocumentFragment by calling range.createContextualFragment
2.Set some string to an element's innerHTML
Actual Results:  
The element additionally includes the contents of DocumentFragment created by createContextualFragment.

Expected Results:  
The element contains only what was assigned.

Comment 1

[sevenfurnace]

Attachment: testcase

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

My guess is that Bug 386769 may have caused this.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Seems pretty likely.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

The basic problem is that the content sink expects to have a short lifetime and therefore not really hang on to the document fragment it produces. That doesn't work well with caching if we then hand the fragment off to some random caller.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 307619 [details] [diff] [review]
Patch, v1

r+sr=jst

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Can you add a mochitest for this as well?

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 307619 [details] [diff] [review]
Patch, v1

Oops, this is blocking.

Comment 8

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch I checked in

This is what I just landed, with a mochitest.

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041323 Minefield/3.0pre ID:2008041323 and the testcase from comment #1